fix(ldif): prevent yaml parser from parsing ldif files#929
Merged
marle3003 merged 1 commit intomarle3003:mainfrom Apr 15, 2026
Merged
fix(ldif): prevent yaml parser from parsing ldif files#929marle3003 merged 1 commit intomarle3003:mainfrom
marle3003 merged 1 commit intomarle3003:mainfrom
Conversation
Owner
|
Thank you for your help in improving Mokapi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ldif files are used, the yaml parser tries to parse these files. That leads to memory usage up to ~1.2 GB for a 170 KB ldif file and over 8 GB for a 2.2 MB ldif file.
With this simple fix, the yaml parser is prevented from parsing ldif files and the memory usage drops to ~12 MB for the 170 KB file and ~32 MB for the 2.2 MB file.