feature/type-checker-compatible-with-mypy#38
feature/type-checker-compatible-with-mypy#38Sooshiance wants to merge 4 commits intomarselester:masterfrom
Conversation
|
Thank you! I'll have a look when I have a chance. |
| @@ -0,0 +1,35 @@ | |||
| repos: | |||
There was a problem hiding this comment.
I don't think we need pre commit hooks.
| @@ -0,0 +1,14 @@ | |||
| [mypy] | |||
There was a problem hiding this comment.
Could you please move this into pyproject.toml, e.g., https://mypy.readthedocs.io/en/stable/config_file.html#example-pyproject-toml?
| @@ -0,0 +1,14 @@ | |||
| [mypy] | |||
| python_version = 3.11 | |||
There was a problem hiding this comment.
I guess python_version is not necessary, for instance, I don't see it in the https://github.com/fastapi/fastapi/blob/master/pyproject.toml#L125.
There was a problem hiding this comment.
Ok, I will task it as an important notice.
| logger.setLevel(logging.DEBUG) | ||
| logging.propagate = False | ||
| # This should be logger, not logging or use `type: ignore` instead | ||
| logger.propagate = False |
There was a problem hiding this comment.
Nice catch 👍. Let's remove the This should be logger ... comment.
| @@ -1,33 +1,37 @@ | |||
| from __future__ import annotations # backward compatibility | |||
There was a problem hiding this comment.
I've deprecated Python < v3.9, could you please rebase? I wonder if we still need from __future__ import annotations.
There was a problem hiding this comment.
Ok, sorry for late responding...
|
OK, sure I will do that
…On Fri, Feb 28, 2025 at 4:06 AM Marsel Mavletkulov ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In json_log_formatter/__init__.py
<#38 (comment)>
:
> @@ -1,33 +1,37 @@
+from __future__ import annotations # backward compatibility
I've deprecated Python < v3.9, could you please rebase? I wonder if we
still need from __future__ import annotations.
—
Reply to this email directly, view it on GitHub
<#38 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AZTUVVKMKIITKPI3SJ5DBPL2R6VPZAVCNFSM6AAAAABWERCQYKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMNBZGQYDGMZYGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I've made your desired changes. If you found any issues, send me a comment. |
|
Thanks! Could you please have a look at the failing tests in Python 3.9? |
2 participants
I've added type checker(compatible with
mypy) to your project, I hope that finds you well