Retain and expose managed export metadata#71
Open
dain wants to merge 1 commit into
Open
Conversation
Systems such as OpenMetrics and OpenTelemetry have their own metric naming conventions. They need the original Java type and generated-name inputs to build those names, while still using the final ObjectName for identity and labels. ObjectNameGenerator collapses that context into a final ObjectName, so consumers otherwise have to reverse-engineer naming intent from JMX properties. Retain the export metadata beside ManagedClass to make that intent available directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ObjectName, which forces consumers to reverse-engineer naming intent from JMX properties.ObjectNamebecause configured generators may rewrite domains or add identity properties used as labels.Approach
ObjectName.ManagedClasswhen available.getManagedClasses()API as a compatibility projection.