Skip to content

🧹 Use context.Background() instead of context.TODO() #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matdev83 merged 3 commits into from
Jul 1, 2026
+10 −1
Merged

🧹 Use context.Background() instead of context.TODO() #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
518f89e
refactor(bedrock): replace context.TODO with context.Background
google-labs-jules[bot] Jul 1, 2026
9b7a783
Merge remote-tracking branch 'origin/main' into fix/context-todo-to-b…
Jul 1, 2026
a962a2f
fix(bedrock): suppress SA1012 on nil-context deadline test
Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/plugins/backends/bedrock/plugin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const DefaultLoadConfigTimeout = 30 * time.Second
// indefinitely. The caller must invoke the returned CancelFunc.
func ensureLoadConfigDeadline(ctx context.Context) (context.Context, context.CancelFunc) {
if ctx == nil {
return context.WithTimeout(context.TODO(), DefaultLoadConfigTimeout)
return context.WithTimeout(context.Background(), DefaultLoadConfigTimeout)
}
if _, ok := ctx.Deadline(); ok {
return ctx, func() {}
Expand Down
9 changes: 9 additions & 0 deletions internal/plugins/backends/bedrock/plugin_deadline_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,15 @@ func TestEnsureLoadConfigDeadline_todoYieldsDeadline(t *testing.T) {
}
}

func TestEnsureLoadConfigDeadline_nilYieldsDeadline(t *testing.T) {
t.Parallel()
c, cancel := ensureLoadConfigDeadline(nil) //nolint:staticcheck // nil ctx: ensureLoadConfigDeadline must coerce to a usable deadline context
defer cancel()
if _, ok := c.Deadline(); !ok {
t.Fatal("expected child deadline when parent is nil")
}
}

func TestEnsureLoadConfigDeadline_backgroundYieldsDeadline(t *testing.T) {
t.Parallel()
c, cancel := ensureLoadConfigDeadline(context.Background())
Expand Down