Skip to content

🧹 Remove deprecated New function in bedrock plugin #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matdev83 merged 1 commit into from
Jul 1, 2026
Merged

🧹 Remove deprecated New function in bedrock plugin #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions internal/plugins/backends/bedrock/plugin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,20 +21,10 @@ func defaultBackendCaps() lipapi.BackendCaps {
}

// DefaultLoadConfigTimeout bounds AWS SDK default configuration loading during backend construction.
// New applies it automatically; composition roots calling NewWithContext should wrap their
// Composition roots calling NewWithContext should wrap their
// context with context.WithTimeout using this duration (or shorter) unless it already carries a deadline.
const DefaultLoadConfigTimeout = 30 * time.Second

// New returns a runtime backend that invokes Bedrock ConverseStream via the AWS SDK v2.
//
// Deprecated: prefer [NewWithContext] with a context whose deadline reflects your bootstrap
// budget. New applies [DefaultLoadConfigTimeout] around AWS config load only.
func New(cfg Config) execbackend.Backend {
ctx, cancel := context.WithTimeout(context.Background(), DefaultLoadConfigTimeout)
defer cancel()
return NewWithContext(ctx, cfg)
}

// ensureLoadConfigDeadline returns a context for awsconfig.LoadDefaultConfig. If ctx is nil, or
// has no deadline, it wraps with [DefaultLoadConfigTimeout] so config load cannot hang
// indefinitely. The caller must invoke the returned CancelFunc.
Expand All @@ -48,7 +38,7 @@ func ensureLoadConfigDeadline(ctx context.Context) (context.Context, context.Can
return context.WithTimeout(ctx, DefaultLoadConfigTimeout)
}

// NewWithContext returns a runtime backend like [New], using ctx for awsconfig.LoadDefaultConfig.
// NewWithContext returns a runtime backend, using ctx for awsconfig.LoadDefaultConfig.
// A deadline is always applied for the load step: either ctx's own deadline, or
// [DefaultLoadConfigTimeout] when ctx is nil or uncancelled without a deadline.
func NewWithContext(ctx context.Context, cfg Config) execbackend.Backend {
Expand Down