Skip to content

small multiples [DRAFT]#685

Open
stephanietuerk wants to merge 6 commits into
mainfrom
684-bugviz-axis-ticks-dont-draw-ticks-at-all-is-tickssize0
Open

small multiples [DRAFT]#685
stephanietuerk wants to merge 6 commits into
mainfrom
684-bugviz-axis-ticks-dont-draw-ticks-at-all-is-tickssize0

Conversation

@stephanietuerk

Copy link
Copy Markdown
Contributor

No description provided.

@stephanietuerk stephanietuerk requested a review from Copilot June 12, 2025 23:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new property, marksDisplay, to control the display of tick marks in the visualization axes. The key changes include:

  • Adding the marksDisplay property in both Ticks and TicksOptions.
  • Implementing a new builder method marksDisplay() and updating the build process in TicksBuilder and QuantitativeTicksBuilder.
  • Integrating the new property into the axis rendering logic and updating the API documentation.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
libs/viz-components/src/lib/axes/ticks/ticks.ts Added marksDisplay property to the Ticks class.
libs/viz-components/src/lib/axes/ticks/ticks-options.ts Added marksDisplay property to the TicksOptions interface.
libs/viz-components/src/lib/axes/ticks/ticks-builder.ts Introduced _marksDisplay field, added marksDisplay() method, and updated the build process to include marksDisplay.
libs/viz-components/src/lib/axes/base/xy-axis-base.ts Updated axis rendering logic to remove tick lines based on marksDisplay.
apps/demo-app/src/assets/viz-components/content/xy-axis-ticks.md Updated documentation to include information on the marksDisplay builder method.

Comment thread libs/viz-components/src/lib/axes/ticks/ticks-builder.ts
@stephanietuerk

Copy link
Copy Markdown
Contributor Author

beta-release-bot: viz-components

@github-actions

Copy link
Copy Markdown

Beta Release Workflow (viz-components): Succeeded ✅

To install, run npm install @hsi/viz-components@1.0.0-beta.3

@stephanietuerk

Copy link
Copy Markdown
Contributor Author

beta-release-bot: viz-components

@github-actions

Copy link
Copy Markdown

Beta Release Workflow (viz-components): Succeeded ✅

To install, run npm install @hsi/viz-components@1.0.0-beta.4

@stephanietuerk

Copy link
Copy Markdown
Contributor Author

beta-release-bot: viz-components

@github-actions

Copy link
Copy Markdown

Beta Release Workflow (viz-components): Succeeded ✅

To install, run npm install @hsi/viz-components@1.0.0-beta.5

@stephanietuerk

Copy link
Copy Markdown
Contributor Author

beta-release-bot: viz-components

@github-actions

Copy link
Copy Markdown

Beta Release Workflow (viz-components): Succeeded ✅

To install, run npm install @hsi/viz-components@1.0.0-beta.5

@stephanietuerk

Copy link
Copy Markdown
Contributor Author

beta-release-bot: viz-components

@github-actions

Copy link
Copy Markdown

Beta Release Workflow (viz-components): Succeeded ✅

To install, run npm install @hsi/viz-components@1.0.0-beta.5

@stephanietuerk stephanietuerk changed the title fix: add marksDisplay property fix: add marksDisplay property - OLD Jun 17, 2025
@tcoile tcoile changed the title fix: add marksDisplay property - OLD small multiples [DRAFT] Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants