Open
Conversation
james-hill-matomo
force-pushed
the
add-phpstan
branch
from
4d6ca1e to
944b910
Compare
james-hill-matomo
force-pushed
the
add-phpstan
branch
from
944b910 to
2331dd6
Compare
lachiebol
requested changes
Mar 24, 2026
Contributor
lachiebol
left a comment
lachiebol
left a comment
There was a problem hiding this comment.
Just a question around modified/created and one error
| PHPSTAN_BASE_CONFIG=phpstan.neon | ||
| if [[ -f "$PHPSTAN_BASE_CONFIG" ]]; then | ||
| echo "Running PHPstan at a base level on all plugin files" | ||
| $COMMAND analyse -c ${PLUGIN_PATH}/${PHPSTAN_BASE_CONFIG} || STATUS=1 |
Contributor
There was a problem hiding this comment.
The other plugins only ran the pre-push on modified/created, should we also do that one like this?
https://github.com/innocraft/plugin-Cohorts/blob/5.x-dev/.git-hooks-matomo/phpstan-pre-push.sh
Contributor
There was a problem hiding this comment.
I also got this error
Running pre-commit hook in repo: /home/lachlan/matomo-code/matomo_5x-dev/plugins/AnonymousPiwikUsageMeasurement
Running PHPstan at a base level on all plugin files
Project config file at path /phpstan.neon does not exist.
error: failed to push some refs to 'https://github.com/matomo-org/plugin-AnonymousPiwikUsageMeasurement.git'
Contributor
There was a problem hiding this comment.
I think the rationale for only doing modified/created is that phpstan will run on everything anyways with the workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simplified the setup, refactored pre-push.