Repository navigation
Label and request review on vendored dependency and release date pull requests - #36
Merged
Merged
Conversation
…pens Only a newly opened pull request requests review, so the weekly refresh does not notify the reviewers again while it is in review.
Requests review on any run while nobody is requested and nobody has reviewed, instead of only on the run that opens the pull request.
…on a person A release that merges itself notifies nobody. The vendored deps step can't be shared, since its write-token job runs nothing from workflows-ref.
snake14
enabled auto-merge (squash)
October 19, 2026 22:40
AltamashShaikh
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The vendored dependencies update now labels its pull request
Needs Reviewand requests review from the organisation's plugin reviewer team, so an update pull request no longer sits unnoticed until someone goes looking for it.The team is
plugin-reviewersin matomo-org andpremium-plugins-reviewersin innocraft, and a newreviewer-teaminput overrides it. Review is requested only while nobody is requested and nobody has reviewed, so the weekly refresh does not notify a team that is already reviewing, and a request GitHub refuses is retried on the next refresh. A refused request fails the run with GitHub's reason. WithoutDEPS_PR_TOKEN, or in an organisation with no known team, no review is requested and the run warns when the pull request is opened.The request is made with
DEPS_PR_TOKEN, so that token now needs to be able to request a team review as well as push and open the pull request. The README and the secret's description say so.The weekly release workflow does the same for its release date pull request, but only when that pull request waits on a person: left open, or set to auto-merge but held by a required review or requested changes. A release that merges itself notifies nobody. The label is added with the workflow's token and review is requested with
approver-token; without that token the pull request is labelled and the run warns.plugin-dev-release.ymlgets the samereviewer-teaminput.Issue No
N/A
Steps to Replicate the Issue
Checklist