fix divByZero#24355
Merged
Merged
Conversation
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
…xone into 0512-fix-divzero
XuPeng-SH
approved these changes
May 13, 2026
Contributor
XuPeng-SH
left a comment
XuPeng-SH
left a comment
There was a problem hiding this comment.
Review
Fix is correct — the two bugs (cache leakage across statements, PREPARE/EXECUTE using wrong stmt type) are properly addressed. The approach of decoupling divByZero-specific stmtType/queryType/ignore from the session-level fields is clean. Test coverage is comprehensive.
Minor nits (non-blocking)
-
Redundant
elseafterreturnincheckDivisionByZeroBehavior— theif ignore { return false } else { return true }pattern is non-idiomatic Go. Drop theelse. -
getStatementType(statement)called twice inrefreshProcessDivByZeroProfileForPreparedStmt— cache the intermediate result. -
clearDivByZeroRuntimeProfileinsideSetStmtProfile— this creates an implicit contract that callers must callSetDivByZeroRuntimeProfileafterSetStmtProfile. Consider a comment documenting this, since a future caller ofSetStmtProfilemight not know they need to follow up.
LGTM.
Contributor
Merge Queue Status
This pull request spent 1 hour 2 minutes 11 seconds in the queue, with no time running CI. Waiting for any of
All conditions
ReasonThe merge conditions cannot be satisfied due to failing checks HintYou may have to fix your CI before adding the pull request to the queue again. |
Contributor
Author
|
@mergify refresh |
Contributor
✅ Pull request refreshed |
Contributor
Author
|
@mergify refresh |
Contributor
✅ Pull request refreshed |
Contributor
Merge Queue Status
This pull request spent 24 seconds in the queue, including 3 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #23438
What this PR does / why we need it:
#23438 在最新的main未复现.
此pr修改:
1, 多语句情景下, 问题: 前一个语句的DivByZeroErrorMode 会继承成给下一个条语句.
2, prepare/execute 场景下 insert/insert ignore的行为. execute与 实际执行的语句 是不同的. 为divByZero单独增加了stmtType, queryType和Ignore. 与主语句的相关变量区分开.