Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughDocumentation updates across multiple configuration and setup guides, including version bump to Sphinx 11.6, new OpenID Connect Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related issues
Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Newest code from mattermost has been published to preview environment for Git SHA c2a1f0b |
|
Newest code from mattermost has been published to preview environment for Git SHA 94e2caf |
|
Newest code from mattermost has been published to preview environment for Git SHA 8ba0a05 |
|
Newest code from mattermost has been published to preview environment for Git SHA d96cfdf |
|
Newest code from mattermost has been published to preview environment for Git SHA 400979b |
|
Newest code from mattermost has been published to preview environment for Git SHA e7cf770 |
|
Newest code from mattermost has been published to preview environment for Git SHA acc073c |
|
Newest code from mattermost has been published to preview environment for Git SHA 079e105 |
Adds notes to end-user search docs and admin config docs clarifying that 7zip (.7z) files are not supported for file content search and are skipped for security reasons. Only standard ZIP files are supported when ZIP file search is enabled. Ref: mattermost/mattermost#34983 Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Adds Use preferred username setting documentation to each OpenID Connect provider section (GitLab, Google, Entra ID, OpenID Connect other) in the authentication configuration settings reference, and a corresponding note in the OpenID Connect SSO setup guide. Closes #8835 Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com> Co-authored-by: Combs7th <Combs7th@users.noreply.github.com>
|
Newest code from mattermost has been published to preview environment for Git SHA 8fe3cb9 |
|
Newest code from mattermost has been published to preview environment for Git SHA 0dd3511 |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
source/administration-guide/configure/authentication-configuration-settings.rst (1)
2249-2266: Consider adding contextual guidance on when to enable "Use preferred username".The documentation clearly describes the configuration settings for enabling
preferred_usernameclaim usage across all four OpenID Connect providers (GitLab, Google, Entra ID, and Other). However, it lacks guidance on:
- When administrators should enable this feature versus using the default behaviour
- What the fallback behaviour is if the
preferred_usernameclaim is unavailable or empty- Potential username conflicts or implications when enabling this after users have already been created
Consider adding a general note at the beginning of the OpenID Connect section (around line 2117-2140) that explains:
- The default username claim behaviour (what attribute is used when this setting is false)
- Use cases for enabling
preferred_username(e.g., organizational naming conventions, compatibility with other systems)- Behaviour if the claim is missing (does login fail, or does it fall back to another claim?)
- Impact on existing users (are usernames updated on next login?)
This would help administrators make informed decisions about enabling these settings.
📋 Suggested addition for better context
Consider adding a note similar to this before the provider-specific sections:
OpenID Connect --------------- Access the following configuration settings in the System Console by going to **Authentication > OpenID Connect**. +.. note:: + By default, Mattermost derives usernames from the email or sub claims in OpenID Connect tokens. The **Use preferred username** + setting allows you to use the ``preferred_username`` claim instead, which may better match your organization's naming conventions. + Ensure your OpenID Connect provider includes this claim in the token before enabling this setting. .. config:setting:: select-openid-connect-service-providerAlso applies to: 2344-2361, 2459-2479, 2596-2615
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@source/administration-guide/configure/authentication-configuration-settings.rst` around lines 2249 - 2266, Add a short general note at the start of the OpenID Connect section (before the provider-specific blocks) explaining the default username-claim behaviour and guidance for admins: state that when oidc-gitlabusepreferredusername / GitLabSettings.UsePreferredUsername (and the equivalent settings for Google, Entra ID, Other) is false the server uses the provider's default username claim (e.g., email or sub) for account names; list common use cases for enabling preferred_username (organizational naming conventions, SSO compatibility); describe fallback behaviour if preferred_username is missing or empty (fall back to the provider's default claim rather than failing login); and warn about impact on existing users (usernames are not retroactively renamed but may influence new/linked accounts or username conflicts on next login), so admins can decide whether to enable MM_GITLABSETTINGS_USEPREFERREDUSERNAME (and the corresponding env/config settings for other providers).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@source/end-user-guide/collaborate/search-for-messages.rst`:
- Line 89: Replace the nonstandard product name "7zip" in the sentence that
currently reads "7zip (``.7z``) files are not supported…" with the correct
branding "7-Zip" or rephrase to ".7z archives" so the sentence reads e.g. "7-Zip
(``.7z``) files are not supported for file content search…" or "`.7z` archives
are not supported for file content search…"; update the instance of "7zip" and
keep the existing mention of ".7z" and the rest of the sentence intact.
---
Nitpick comments:
In
`@source/administration-guide/configure/authentication-configuration-settings.rst`:
- Around line 2249-2266: Add a short general note at the start of the OpenID
Connect section (before the provider-specific blocks) explaining the default
username-claim behaviour and guidance for admins: state that when
oidc-gitlabusepreferredusername / GitLabSettings.UsePreferredUsername (and the
equivalent settings for Google, Entra ID, Other) is false the server uses the
provider's default username claim (e.g., email or sub) for account names; list
common use cases for enabling preferred_username (organizational naming
conventions, SSO compatibility); describe fallback behaviour if
preferred_username is missing or empty (fall back to the provider's default
claim rather than failing login); and warn about impact on existing users
(usernames are not retroactively renamed but may influence new/linked accounts
or username conflicts on next login), so admins can decide whether to enable
MM_GITLABSETTINGS_USEPREFERREDUSERNAME (and the corresponding env/config
settings for other providers).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a632a923-d546-4fa6-9a5a-14b43c700ddb
📒 Files selected for processing (4)
source/administration-guide/configure/authentication-configuration-settings.rstsource/administration-guide/configure/environment-configuration-settings.rstsource/administration-guide/onboard/sso-openidconnect.rstsource/end-user-guide/collaborate/search-for-messages.rst
✅ Files skipped from review due to trivial changes (2)
- source/administration-guide/onboard/sso-openidconnect.rst
- source/administration-guide/configure/environment-configuration-settings.rst
|
Newest code from mattermost has been published to preview environment for Git SHA d00703a |
|
Newest code from mattermost has been published to preview environment for Git SHA 80e718a |
|
Newest code from mattermost has been published to preview environment for Git SHA f7ab14f |
* Prepare v11.6 feature release docs (April 16, 2026) Co-authored-by: Amy Blais <amyblais@users.noreply.github.com> * Update important-upgrade-notes.rst * Update deprecated-features.rst * Update release-policy.md * Update mattermost-v11-changelog.md * Update software-hardware-requirements.rst * Update open-source-components.rst * Update mattermost-v11-changelog.md * Update ui-ada-changelog.rst * Update ui-ada-changelog.rst * Update mattermost-v11-changelog.md * Update mattermost-desktop-releases.md * Update mattermost-v11-changelog.md * Update mattermost-v11-changelog.md * Update mattermost-v11-changelog.md * Update mattermost-v11-changelog.md * Update mattermost-v11-changelog.md * Update mattermost-v11-changelog.md * Update mattermost-v11-changelog.md * Update mattermost-v11-changelog.md * Update source/product-overview/mattermost-v11-changelog.md Co-authored-by: Doug Lauder <wiggin77@warpmail.net> * Update mattermost-v11-changelog.md * Update mattermost-v11-changelog.md * Update mattermost-v11-changelog.md * Update ui-ada-changelog.rst * Update mattermost-v11-changelog.md * Update important-upgrade-notes.rst * Update mattermost-v11-changelog.md * Update mattermost-v11-changelog.md * Update mattermost-v11-changelog.md * Update mattermost-v11-changelog.md * Update mattermost-v11-changelog.md * Update mattermost-v11-changelog.md * Update ui-ada-changelog.rst * Update mattermost-v11-changelog.md * Update mattermost-v11-changelog.md * Update mattermost-v11-changelog.md * Update mattermost-v11-changelog.md * Update mattermost-v11-changelog.md * Update ui-ada-changelog.rst * Update mattermost-v11-changelog.md * Update ui-ada-changelog.rst --------- Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com> Co-authored-by: Amy Blais <amyblais@users.noreply.github.com> Co-authored-by: Doug Lauder <wiggin77@warpmail.net>
|
Newest code from mattermost has been published to preview environment for Git SHA a86bfc5 |
|
Newest code from mattermost has been published to preview environment for Git SHA 83bc2eb |
There was a problem hiding this comment.
Pull request overview
Updates the Mattermost documentation set for the v11.6 release, including release notes/changelogs, version/support tables, and several end-user/admin guides reflecting new UI and configuration capabilities.
Changes:
- Add v11.6 release notes/changelog entries and update release/support timelines.
- Document new/updated features (e.g., OIDC preferred username, anonymous URLs, search popouts, data spillage terminology) across end-user and admin docs.
- Bump various version references (server download links, macOS minimum) and extend upgrade/support guidance.
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| source/product-overview/ui-ada-changelog.rst | Adds v11.6 UI/ADA changelog entries. |
| source/product-overview/release-policy.md | Marks v11.3 as done in the release timeline. |
| source/product-overview/mattermost-v11-changelog.md | Adds the v11.6 release notes section. |
| source/product-overview/mattermost-server-releases.md | Adds v11.6 to the server releases table with download/SBOM links. |
| source/product-overview/mattermost-desktop-releases.md | Updates desktop compatibility list to include v11.6. |
| source/end-user-guide/collaborate/send-messages.rst | Consolidates AI Rewrite instructions across clients. |
| source/end-user-guide/collaborate/search-for-messages.rst | Updates search guidance and adds file search/archive notes. |
| source/end-user-guide/collaborate/flag-messages.rst | Renames/reframes end-user guidance around quarantine/data spillage. |
| source/deployment-guide/software-hardware-requirements.rst | Updates client OS/browser requirements (macOS/Safari). |
| source/deployment-guide/server/preparations.rst | Updates server preparation wording and section structure. |
| source/deployment-guide/server/linux/deploy-tar.rst | Updates “Latest release” tarball URL to 11.6.0. |
| source/deployment-guide/server/linux/deploy-rhel.rst | Updates “Latest release” tarball URL to 11.6.0. |
| source/conf.py | Updates commented version/release references to 11.6. |
| source/administration-guide/upgrade/open-source-components.rst | Adds v11.6.0 server and v2.39.0 mobile NOTICE links. |
| source/administration-guide/upgrade/important-upgrade-notes.rst | Adds a v11.6 upgrade note row. |
| source/administration-guide/onboard/sso-openidconnect.rst | Documents preferred_username mapping option. |
| source/administration-guide/onboard/sso-google.rst | Adds a note about Google Workspace username/email sync behavior. |
| source/administration-guide/manage/admin/generating-support-packet.rst | Expands the list of fields sanitized in support packets (v11.6). |
| source/administration-guide/manage/admin/content-flagging.rst | Renames “Content Flagging” to “Data Spillage Handling” and updates workflow text. |
| source/administration-guide/configure/user-management-configuration-settings.rst | Documents updating Username/AuthData via System Console. |
| source/administration-guide/configure/environment-configuration-settings.rst | Adds .7z clarification for ZIP content search setting. |
| source/administration-guide/configure/authentication-configuration-settings.rst | Adds UsePreferredUsername settings for OIDC providers. |
| Makefile | Adjusts sphinx-autobuild options. |
|
Newest code from mattermost has been published to preview environment for Git SHA 047e01d |
|
Newest code from mattermost has been published to preview environment for Git SHA 35c6138 |
No description provided.