fix: correct inconsistent error message in Exec vs Query (#1395)#1401
Open
vigneshakaviki wants to merge 1 commit into
Open
fix: correct inconsistent error message in Exec vs Query (#1395)#1401vigneshakaviki wants to merge 1 commit into
vigneshakaviki wants to merge 1 commit into
Conversation
…#1395) Exec and Query share the same multi-statement loop and error check, but reported different 'got' argument counts in error messages: - Exec: reported len(args) (total args) - Query: reported len(args)-start (remaining args) Both check the same condition (len(args)-start < na), so both should report the same 'got' value. The correct value is len(args)-start since that's what's compared against the required args. Fixes mattn#1395 Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
Query reported len(args)-start correctly, but Exec reported full len(args)
Changes
Test Plan