guard oversized blob length in callbackRetBlob#1405
Merged
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1405 +/- ##
==========================================
+ Coverage 47.16% 51.45% +4.28%
==========================================
Files 12 13 +1
Lines 1533 1862 +329
==========================================
+ Hits 723 958 +235
- Misses 669 745 +76
- Partials 141 159 +18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Owner
|
Thank you |
Contributor
Author
|
Thanks for the review and merge. Looking forward to contributing more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
callbackRetBlob forwards a custom function's []byte return through C.int(len(bs)) to sqlite3_result_blob, but the sqlite3 C API takes the byte count as a signed int. On 64-bit a return value over 2 GiB narrows to a negative length, and since the docs say a negative length is only defined for text, sqlite3VdbeMemSetStr runs the blob terminator scan off the end of the Go buffer, which has no NUL terminator (OOB read). I noticed it while reading the result paths after the earlier bind/result length fixes. Same guard as ResultBlob/ResultText: reject with sqlite3_result_error_toobig when it would not fit.