Skip to content

Fix detection of dependencies for windows WSL2 (prefer apt-get)#320

Open
ggppdk wants to merge 1 commit into
mbailey:masterfrom
ggppdk:patch-1
Open

Fix detection of dependencies for windows WSL2 (prefer apt-get)#320
ggppdk wants to merge 1 commit into
mbailey:masterfrom
ggppdk:patch-1

Conversation

@ggppdk

@ggppdk ggppdk commented Mar 22, 2026

Copy link
Copy Markdown

Brew is installed in WSL2 but trying to use it to detect dependencies will result in packages reported as not installed

uvx voice-mode deps

Core Dependencies:
✗ python3-dev
✓ gcc
✗ libasound2-dev
✗ libportaudio2
✓ pulseaudio
✗ pulseaudio-utils
✓ ffmpeg

Whisper Dependencies:
✓ git
✓ cmake
✓ gcc
✓ g++
✓ make
✓ libsdl2-dev
✓ portaudio19-dev
✓ libasound2-dev

Kokoro Dependencies:
✓ git

Missing dependencies: python3-dev, libasound2-dev, libportaudio2, pulseaudio-utils

After the patch everything is reported as installed

Brew is installed in WSL2 but trying to use it to detect dependencies will result in packages reported as not installed
@ai-cora

ai-cora commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Thanks — the bug and fix direction are correct and appreciated. We'd just like to route it through voicemode's existing WSL detector (detect_platform() in voice_mode/utils/dependencies/checker.py) instead of a new inline is_wsl2(), so it stays consistent and catches WSL2 kernels that don't carry a literal "WSL2" string (reading /proc/version and matching microsoft/wsl is the established idiom). Moving the import platform/os to module top and adding a ### Fixed CHANGELOG entry would round it out. Appreciated!

1 similar comment
@ai-cora

ai-cora commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Thanks — the bug and fix direction are correct and appreciated. We'd just like to route it through voicemode's existing WSL detector (detect_platform() in voice_mode/utils/dependencies/checker.py) instead of a new inline is_wsl2(), so it stays consistent and catches WSL2 kernels that don't carry a literal "WSL2" string (reading /proc/version and matching microsoft/wsl is the established idiom). Moving the import platform/os to module top and adding a ### Fixed CHANGELOG entry would round it out. Appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants