Repository navigation
Fix external-module regression and automate release version references - #58
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the tools test when bashtest is built as an external module, as BCR does, and exercise the framework suite from an external consumer in CI. Derive consumer versions from the checkout and automate the README version update during release preparation, keeping the installation example on the published release during development.
AG;DR
$(location)against Bazel's$(rootpath)instead of a hardcoded root-workspace path, preserving the existing contract. No runtime API or published 0.7.0 artifact changes.external_consumer_test.shto run@framework//bashtest/tests/...alongside the sample consumer with manifest-only runfiles. Existing CI invokes this script on Linux, macOS, and Windows, using a renamed repository and a workspace path containing spaces.python3 tools/prepare_release.py X.Y.Z: validate the module/changelog and update the README to the intended release. Review and merge that preparation before tagging. The tag helper, including dry runs, and the archive workflow both require--checkto pass. This preserves agreement in the tagged source, archive, and release notes without mutating published artifacts. Preparation does not commit, tag, or publish.bazel test //...(8 applicable tests; Windows runtime test incompatible on macOS), andpre-commit run --all-filespassed. All PR CI checks passed on this head: Linux, macOS, Windows, pre-commit, release-site tests, and the final gate (run 39070227451).