Skip to content

chore: Add gtfs_id to IntermediateStop schema#27

Open
joshlarson wants to merge 2 commits into
mainfrom
jdl/chore/add-gtfs-id-to-intermediate-stops
Open

chore: Add gtfs_id to IntermediateStop schema#27
joshlarson wants to merge 2 commits into
mainfrom
jdl/chore/add-gtfs-id-to-intermediate-stops

Conversation

@joshlarson

Copy link
Copy Markdown
Contributor

Asana Ticket: ⛴️ 💸 Update OTP Client to return GTFS ID's for intermediate stops

One of the things that's making ferry-fare calculation kind of difficult is that ferry fares depend on intermediate stops. Right now, intermediate stops are only given names, which means that fares are calculated based on origin ID, destination ID, and then the names of the intermediate stops. This is bad for a few reasons:

  1. Cognitive overhead - why are these names and these ID's?
  2. This test seems to think the between things are ID's, for instance.
  3. The stop names aren't necessarily stable. For instance, the code is currently looking for stop names "Hingham", "Hull", "Quincy", and "Winthrop", but the stop names are (currently) "Hingham (Hewitts Cove)", "Hull (Pemberton Point)", "Quincy (Squantum Point)", and "Winthrop (Winthrop Landing)".

Their GTFS ID's are available - let's use them!

@joshlarson
joshlarson requested review from a team as code owners July 17, 2026 20:14
@joshlarson
joshlarson requested review from jlucytan and thedecaftony and removed request for a team July 17, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants