Add Python build and packaging configuration - #4
Add Python build and packaging configuration#4mdellison90-stack with Copilot wants to merge 4 commits into
Conversation
Co-authored-by: mdellison90-stack <230609064+mdellison90-stack@users.noreply.github.com>
Co-authored-by: mdellison90-stack <230609064+mdellison90-stack@users.noreply.github.com>
Co-authored-by: mdellison90-stack <230609064+mdellison90-stack@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1903292974
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Repository = "https://github.com/yasinkuyu/binance-trader" | ||
|
|
||
| [tool.setuptools] | ||
| packages = ["app"] |
There was a problem hiding this comment.
Fix packaged imports before declaring
app installable
Packaging app as an installable wheel here produces a broken install: the modules under app/ still rely on repo-root imports such as import config and from Database import Database, so a wheel built from this commit cannot even import app.Trading outside the source checkout. I verified this by extracting the wheel built from pyproject.toml and importing app.Trading, which fails with ModuleNotFoundError; users taking the new package-install path will get an unusable distribution.
Useful? React with 👍 / 👎.
| docker build -t binance-trader . | ||
|
|
||
| docker-run: | ||
| docker run binance-trader |
There was a problem hiding this comment.
Make
docker-run pass the trader's required CLI args
This target always runs docker run binance-trader, but trader.py requires --symbol via argparse before it can start. That means the new make docker-run flow exits immediately for every user, even if the image was built correctly and a valid config is present, so the Makefile now advertises a container run path that is nonfunctional out of the box.
Useful? React with 👍 / 👎.
Repository lacked standardized build configuration and dependency management. Added modern Python packaging setup following PEP 518.
Build Configuration
requests>=2.28.0)install,install-dev,test,lint,format,clean,docker-buildInfrastructure Updates
requirements.txtinstead of inlinepip installPackage can now be installed via
pip install -e .or built as wheel withpython -m build.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.