Skip to content

chore(tests): move from args to commands in cli#1590

Merged
LeoMcA merged 1 commit into
mainfrom
test-commands
May 21, 2026
Merged

chore(tests): move from args to commands in cli#1590
LeoMcA merged 1 commit into
mainfrom
test-commands

Conversation

@LeoMcA

@LeoMcA LeoMcA commented May 20, 2026

Copy link
Copy Markdown
Member

Would recommend reviewing with whitespace changes hidden

Relates to #1588:

Converting the test cli to use commands, and merging the visual-report cli in: using a long string of options makes the command hard to use, and complicates implementation

I think my original idea was to have a single "test" command to run everything locally, but the existing behaviour wasn't giving that, and made life more complicated, requiring me to have a separate command for generating the visual report which I'll merge into the commands here (which PR that happens on depends on which gets merged first!)

This will also make further follow-ups simpler, like being able to run a single test, and some kind of watch mode.

If we need a "run everything" mode we can always add that as another or the default command.

@github-actions

Copy link
Copy Markdown
Contributor

86e7aff was deployed to: https://fred-pr1590.review.mdn.allizom.net/

@LeoMcA LeoMcA marked this pull request as ready for review May 20, 2026 16:17
@LeoMcA LeoMcA requested a review from a team as a code owner May 20, 2026 16:17
@LeoMcA LeoMcA requested a review from caugner May 20, 2026 16:17
@LeoMcA LeoMcA merged commit f3afadc into main May 21, 2026
12 checks passed
@LeoMcA LeoMcA deleted the test-commands branch May 21, 2026 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants