Improve reference docs for setHeader, AbstractSetterInterceptor, AbstractLanguageInterceptor#3035
Improve reference docs for setHeader, AbstractSetterInterceptor, AbstractLanguageInterceptor#3035predic8 wants to merge 2 commits into
Conversation
- SetHeaderInterceptor: add @topic, rewrite @description (constant vs computed, supported languages, tutorial link), fix @yaml to use api:/flow: context and show both a static and a computed (${method}) example - AbstractSetterInterceptor: add @description/@default/@example to all four @MCAttribute setters (name, value, ifAbsent, failOnError); replace the @param-based Javadoc on failOnError that was silently dropped by the renderer - AbstractLanguageInterceptor: fix @description on setLanguage (was a copy-paste from <if>); replace @param comment on setXmlConfig with @description Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis PR updates Javadoc across three interceptor classes: ChangesInterceptor documentation updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@core/src/main/java/com/predic8/membrane/core/interceptor/lang/AbstractSetterInterceptor.java`:
- Around line 133-137: Update the failOnError documentation in
AbstractSetterInterceptor so it applies to both request and response handling,
since handleResponse() uses the same path as request processing. Widen the
wording from “the request continues unchanged” to “the flow/message continues
unchanged” while keeping the existing behavior and references to failOnError,
handleResponse(), and the expression evaluation error handling consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 9f9c7854-9562-4714-8f61-4344fc50d002
📒 Files selected for processing (3)
core/src/main/java/com/predic8/membrane/core/interceptor/lang/AbstractLanguageInterceptor.javacore/src/main/java/com/predic8/membrane/core/interceptor/lang/AbstractSetterInterceptor.javacore/src/main/java/com/predic8/membrane/core/interceptor/lang/SetHeaderInterceptor.java
|
/ok-to-test |
Summary
SetHeaderInterceptor: add@topic, rewrite@description(constant vs computed value, supported languages, tutorial link), fix@yamlto use the properapi:/flow:context and show both a static (Membrane) and a computed (${method}) example side by sideAbstractSetterInterceptor: add@description/@default/@exampleto all four@MCAttributesetters (name,value,ifAbsent,failOnError); replace the@param-based Javadoc onfailOnErrorthat was silently dropped by the rendererAbstractLanguageInterceptor: fix@descriptiononsetLanguage(was a copy-paste from<if>that said "test condition"); replace@paramcomment onsetXmlConfigwith a proper@descriptiontag (previously invisible to the renderer)Test plan
mvn -q -o -pl core compilepasses with no warnings (verified locally)docs.yamlviaMEMBRANE_GENERATE_DOC_DIR=/tmp/docs mvn -q -o -pl core compile— all four attributes ofsetHeadershould have non-empty descriptions@yamlexample matches the tutorial atdistribution/tutorials/getting-started/60-SetHeader.yaml🤖 Generated with Claude Code
Summary by CodeRabbit