feat: HA chart improvements#227
Conversation
044e829 to
a80b4a0
Compare
5e423e9 to
d5ed182
Compare
01234ef to
901b03a
Compare
33b62d8 to
e81f5c9
Compare
|
Release notes: |
antejavor
left a comment
There was a problem hiding this comment.
Here is codex take.
- P1 - Existing HA auth-secret support is broken by reusing secrets for license data. The PR changes secrets to only mean license/org keys in values.yaml#L150
( ), and the pods now only inject MEMGRAPH_ENTERPRISE_LICENSE / MEMGRAPH_ORGANIZATION_NAME in
data.yaml#L181 ( ) and coordinators.yaml#L184
( ). The old secrets.enabled/userKey/passwordKey path for MEMGRAPH_USER / MEMGRAPH_PASS
WORD is removed, so existing values either stop setting auth env vars or point the new license lookup at the old auth secret. Use a separate license secret key path or preserve the old auth block.
@as51340 I think this is fine since we are breaking the process.
- P1 - AKS Terraform quick start now deploys a chart that requires a secret Terraform never creates. The AKS README still describes Terraform as the full setup in aks/README.md#L16
( ), and the Helm release only reads values_file in aks/main.tf#L82
( ). Since the chart now unconditionally references memgraph-secrets, the advertised terraform apply path
will leave pods stuck unless the user manually creates the secret first. Add a Kubernetes secret resource/input to Terraform or make the quick start create it before helm_release.
@as51340 I can see you added that.
- P2 - Coordinator defaults lost --storage-snapshot-on-exit=false. Data instances still keep it in values.yaml#L372
( ), but coordinators now have empty args in values.yaml#L387
( ) and the template only auto-appends ports/logging in coordinators.yaml#L176
( ). The repo’s default config has snapshot-on-exit enabled, so upgrades change coordin
ator shutdown behavior while leaving termination grace at 30s. Keep the old coordinator flag or document the behavior change.
@as51340 not sure about this P2 in the end, is this expected?
And few of my comments below (take what you find needed).
all good |
Read-only root filesystem change is connected to memgraph/mgconsole#96 because
mgconsoleuses a history file by default from/home/memgraph/.memgraph. Now, we will use env variableMGCONSOLE_HISTORY_PATH.The
envsection is removed because the new default way of setting license key and organisation name will be through secrets. Secrets will not support anymore setting user through env variables, users should manually create users by running Cypher queries on data instances. The current design was not clean enough because env variables were also applied to coordinators which didn't make any sense since coordinators are running without auth.Fixed the bug when boolean value is passed as label value with
nodeSelectionenabled.Fixed the bug with namespace usage in vmagent.