Skip to content

feat: HA chart improvements#227

Merged
as51340 merged 12 commits into
mainfrom
feat/ha-chart-improvements
May 4, 2026
Merged

feat: HA chart improvements#227
as51340 merged 12 commits into
mainfrom
feat/ha-chart-improvements

Conversation

@as51340

@as51340 as51340 commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

Read-only root filesystem change is connected to memgraph/mgconsole#96 because mgconsole uses a history file by default from /home/memgraph/.memgraph. Now, we will use env variable MGCONSOLE_HISTORY_PATH.

The env section is removed because the new default way of setting license key and organisation name will be through secrets. Secrets will not support anymore setting user through env variables, users should manually create users by running Cypher queries on data instances. The current design was not clean enough because env variables were also applied to coordinators which didn't make any sense since coordinators are running without auth.

Fixed the bug when boolean value is passed as label value with nodeSelection enabled.
Fixed the bug with namespace usage in vmagent.

@as51340 as51340 self-assigned this Apr 22, 2026
@as51340 as51340 force-pushed the feat/ha-chart-improvements branch 2 times, most recently from 044e829 to a80b4a0 Compare April 22, 2026 08:32
@as51340 as51340 added breaking docs-needed Set if you think documentation needs to be updated because of this change labels Apr 22, 2026
@as51340 as51340 force-pushed the feat/ha-chart-improvements branch from 5e423e9 to d5ed182 Compare April 22, 2026 10:21
@as51340 as51340 added the memgraph-ha Memgraph HA chart issue label Apr 22, 2026
@as51340 as51340 force-pushed the feat/ha-chart-improvements branch 3 times, most recently from 01234ef to 901b03a Compare April 22, 2026 11:42
@as51340 as51340 marked this pull request as ready for review April 23, 2026 06:02
Comment thread charts/memgraph-high-availability/aks/values-aks.yaml Outdated
Comment thread charts/memgraph-high-availability/aks/values-aks.yaml Outdated
@as51340 as51340 added feature New non-breaking feature docs-changelog-only If changelog is enough for this change, no need to update docs. docs-not-needed Docs not needed for such a change and removed feature New non-breaking feature labels Apr 24, 2026
@as51340 as51340 modified the milestone: Memgraph-0.1.4 Apr 24, 2026
@as51340 as51340 force-pushed the feat/ha-chart-improvements branch from 33b62d8 to e81f5c9 Compare April 24, 2026 08:00
@as51340 as51340 added this to the 6th May 2026 milestone Apr 24, 2026
@as51340 as51340 removed docs-changelog-only If changelog is enough for this change, no need to update docs. docs-not-needed Docs not needed for such a change labels May 4, 2026
@as51340

as51340 commented May 4, 2026

Copy link
Copy Markdown
Collaborator Author

Release notes:
Fixes the bug when boolean value is passed to affinity.dataNodeLabelValue or affinity.coordinatorNodeLabelValue by using quote function on the passed argument. Boolean values are often used with Portworx storage. #227
Fixes the bug with vmagent deployment when both vmagentRemote.namespace and prometheus.namespace aren't specified by defaulting the vmagent.namespace to the release namespace. #227
All StatefulSets now use readOnlyRootFilesystem. Because of that, StatefulSets automatically pass env variables DGL_DOWNLOAD_DIR=/tmp/.dgl, DGLDEFAULTDIR=/tmp/.dgl and MGCONSOLE_HISTORY_PATH=/tmp/.memgraph. Because of this, /tmp is provided as emptyDir scratch space. #227
The chart now auto-appends --bolt-port, --management-port, --coordinator-port, --coordinator-id, --coordinator-hostname, --data-directory, --log-level, --also-log-to-stderr and --log-file from ports.* and commonArgs.{data,coordinators}.logging.*. Setting any of these in data[].args or coordinators[].args causes helm install to fail with a template error. #227
The secrets.enabled, secrets.userKey and secrets.passwordKey values have been removed because
the previous implementation also applied these env variables to coordinators, which run without auth. The memgraph-secrets Secret is now reserved for the license and organization name. #227
The HA chart no longer accepts the license and organization name as plaintext values via env.MEMGRAPH_ENTERPRISE_LICENSE and env.MEMGRAPH_ORGANIZATION_NAME. Both values are now read from a Kubernetes Secret referenced via secretKeyRef, and the secret must exist before you run
helm install
— the StatefulSets will fail to start otherwise. The previous
env.* values have been removed from values.yaml. #227
Added new configuration value coreDumpsImage.repository, coreDumpsImage.tag, coreDumpsImage.pullPolicy, prometheus.extraVolumes, prometheus.extraVolumeMounts, commonArgs.data.logging.log_level, commonArgs.data.logging.also_log_to_stderr, commonArgs.data.logging.log_file, commonArgs.coordinators.logging.log_level, commonArgs.coordinators.logging.also_log_to_stderr, commonArgs.coordinators.logging.log_file. #227

@antejavor antejavor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is codex take.

@as51340 I think this is fine since we are breaking the process.

  • P1 - AKS Terraform quick start now deploys a chart that requires a secret Terraform never creates. The AKS README still describes Terraform as the full setup in aks/README.md#L16
    (
    ## Automated setup with Terraform
    ), and the Helm release only reads values_file in aks/main.tf#L82
    (
    resource "helm_release" "memgraph_ha" {
    ). Since the chart now unconditionally references memgraph-secrets, the advertised terraform apply path
    will leave pods stuck unless the user manually creates the secret first. Add a Kubernetes secret resource/input to Terraform or make the quick start create it before helm_release.

@as51340 I can see you added that.

@as51340 not sure about this P2 in the end, is this expected?

And few of my comments below (take what you find needed).

Comment thread charts/memgraph-high-availability/templates/vmagent/_helpers.tpl
Comment thread charts/memgraph-high-availability/templates/vmagent/_helpers.tpl
Comment thread charts/memgraph-high-availability/aks/values-aks.yaml
Comment thread charts/memgraph/templates/mg-exporter.yaml
@as51340

as51340 commented May 4, 2026

Copy link
Copy Markdown
Collaborator Author

@as51340 not sure about this P2 in the end, is this expected?

all good

@as51340 as51340 merged commit 0c8ded0 into main May 4, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking docs-needed Set if you think documentation needs to be updated because of this change memgraph-ha Memgraph HA chart issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants