enum Rav1dError: rename fields to more Rusty versions and add docs#1442
Merged
Conversation
kkysen
reviewed
Jul 7, 2025
kkysen
reviewed
Jul 7, 2025
kkysen
reviewed
Jul 7, 2025
kkysen
reviewed
Jul 7, 2025
kkysen
reviewed
Jul 7, 2025
kkysen
changed the title
enum Rav1dError: rename fields to more Rusty versions and add docs
kkysen
requested changes
Jul 8, 2025
djc
reviewed
Jul 8, 2025
kkysen
requested changes
Jul 14, 2025
Collaborator
kkysen
left a comment
kkysen
left a comment
There was a problem hiding this comment.
Sorry I took a while to get back to finish reviewing this. It's almost done now, I think. And then one other thing, for suggested changes that you accept, could you give the commit a descriptive message instead of the default Update file.rs message? Or if it's small, you can squash it into another commit as well. Thanks!
kkysen
reviewed
Jul 14, 2025
leo030303
force-pushed
the
rename-rav1derror-values
branch
from
53b1521 to
d5828ca
Compare
Co-authored-by: Khyber Sen <kkysen@gmail.com>
Co-authored-by: Khyber Sen <kkysen@gmail.com>
kkysen
force-pushed
the
rename-rav1derror-values
branch
from
d5828ca to
c78c66c
Compare
Co-authored-by: Khyber Sen <kkysen@gmail.com>
kkysen
force-pushed
the
rename-rav1derror-values
branch
from
c78c66c to
bbfa211
Compare
kkysen
approved these changes
Jul 15, 2025
Collaborator
kkysen
left a comment
kkysen
left a comment
There was a problem hiding this comment.
LGTM now! I also fixed up some of the commits a bit. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulled out the
Rav1dErrorchanges from #1439 into a separate PR.