fix: add max-width and adjust tab wrapper margins#109
Open
felixhirschfeld wants to merge 1 commit intomengmeet:mainfrom
Open
fix: add max-width and adjust tab wrapper margins#109felixhirschfeld wants to merge 1 commit intomengmeet:mainfrom
felixhirschfeld wants to merge 1 commit intomengmeet:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aims to fix #106
I used -2.8vw as margin because the tabs also have viewport based padding, and I added max-width: 100% so the layout doesn’t overflow the container anymore.
this fixes it from breaking on Steam Client beta and maybe future Steam updates
I tested on my Zotac Zone with:
PS:
calc(100vw - 50px) could probably also be replaced with 94.4vw, but I left that out for now to keep the change small.
We could probably also pull the value from gamepadTabbedPageClasses.contentPadding and turn it into a matching negative margin, but I didn’t want to overcomplicate this 🤣