[pull] main from hashicorp:main#345
Merged
Merged
Conversation
…ne spacings in human output. Add output for unhappy path. (#38823) Enables colourised output in `state migrate` command, enabling formatting human-readable output. Also, add empty lines to human output to separate distinct parts of the output. Also, this change adds user-facing messages for unhappy paths. Users need some reassurance that their state is ok when an error happens, and also need a heads up when the failing command has impacted the destination location before erroring. Finally this change enables tests to assert that log output matches parameterized human output golden references. Those files are expected to be identifiable by filename: output-parameterized.log.
… migrate` is run with `-force-copy`. (#38882) Pre-existing state migration logic in the Meta's `backendMigrateState` method was originally written only for use with `init`. In `init` users are expected to supply the `-force-copy` to suppress prompts about copying state data. State migrations in automation require `-input=false -force-copy`. In `state migrate` we have to decide how to handle the prompts suppressed by `-force-copy` in the init command. Due to approving a migration being analogous to approving a plan created during an apply command, which requires `-input=false -auto-approve` to run in automation, we add a `-force-copy` flag to the state migrate command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )