fix: deduplicate graph breaks in tlparse summary#182
Conversation
Adds a 'Distinct Graph Breaks' section to the tlparse HTML index that shows each unique graph break reason only once, removing duplicate entries that make it hard for end users to identify which graph breaks need fixing. Previously, tlparse listed every graph break occurrence including duplicates in the Failures and Restarts section. This change collects distinct graph break reasons from restart entries and displays them in a new dedicated section at the top of the index page. Fixes pytorch/pytorch#153669 Test Plan: - Verified with cargo check (no compilation errors) - The change only affects the HTML output of tlparse; existing Failures and Restarts section is preserved unchanged. PR authored with AI assistant.
|
Hi @TheChyeahhh! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Summary
Adds a Distinct Graph Breaks section to the tlparse HTML index page that shows each unique graph break reason only once, removing duplicate entries that make it hard for end users to identify which graph breaks need fixing.
Problem
Previously, tlparse listed every graph break occurrence including duplicates in the Failures and Restarts section. Users had to manually sift through repeated identical break reasons to understand what actually needs fixing.
Solution
This change collects distinct graph break reasons from restart entries (using deduplication via Vec::contains) and displays them in a new dedicated 'Distinct Graph Breaks' section at the top of the index page. The existing Failures and Restarts section is preserved unchanged for detailed inspection.
Changes
Fixes pytorch/pytorch#153669
Test Plan
PR authored with AI assistant.