Skip to content

Fix Windows CUDA builds, maybe#1468

Merged
NicolasHug merged 2 commits into
meta-pytorch:mainfrom
NicolasHug:fixwindowscuda
Jun 1, 2026
Merged

Fix Windows CUDA builds, maybe#1468
NicolasHug merged 2 commits into
meta-pytorch:mainfrom
NicolasHug:fixwindowscuda

Conversation

@NicolasHug
Copy link
Copy Markdown
Contributor

No description provided.

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Jun 1, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/meta-pytorch/torchcodec/1468

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jun 1, 2026
@NicolasHug NicolasHug merged commit 54c4091 into meta-pytorch:main Jun 1, 2026
13 checks passed
@sh202603
Copy link
Copy Markdown

sh202603 commented Jun 1, 2026

Hi @NicolasHug,

Thanks for the quick follow-up here.

Verified locally on the same Windows source-build setup that originally needed the /Zc:preprocessor env-var workaround (torch 2.11.0+cu130 / CUDA 13.2 / MSVC 14.44 / Win11).

Before this PR I had to set both CXXFLAGS=/Zc:preprocessor and CUDAFLAGS=-Xcompiler=/Zc:preprocessor before uv pip install -e ../torchcodec --no-build-isolation, otherwise the CCCL headers pulled in by color_conversion.cu failed with error C1189. With 54c4091e I built cleanly with both env vars unset — the COMPILE_LANGUAGE:CUDA-gated option is sufficient on its own, and the .cpp side does not appear to need the flag at this revision either.

So the "maybe" can be promoted to "yes" at least for this configuration. For other Windows source-build users this is a strict simplification — no need to set the two /Zc:preprocessor env vars anymore!

@NicolasHug NicolasHug deleted the fixwindowscuda branch June 1, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants