Reduce size of built docs#1470
Merged
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/meta-pytorch/torchcodec/1470
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 15 PendingAs of commit e9685f0 with merge base 54c4091 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Contributor
Author
|
Built docs artifact is just ~20MB now, still not insignificant but mangeable, and 10X smaller than before |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We started getting a few warnings upon upload of our docs because they started getting really, really big - about 200Mb which is unreasonable for just a bunch of html files.
The issue was that when we use
play_audioorplay_video, the input is checked-in into the built docs artifacts. Meaning that we were storing large raw wav files, as well as large video files. This PR skips / reduces the amount of stuff we have to keep around. The audio example went from 60Mb to ~3, and the video example went from 45 to ~3.This should account for 100Mb * 2 (since I think they were also duplicated). Let's see.