Use Encoder as backend of AudioEncoder and VideoEncoder#1478
Open
NicolasHug wants to merge 4 commits into
Open
Use Encoder as backend of AudioEncoder and VideoEncoder#1478NicolasHug wants to merge 4 commits into
NicolasHug wants to merge 4 commits into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/meta-pytorch/torchcodec/1478
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ae049e1 with merge base 513d73b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: benchmark
This PR replaces the AudioEncoder and VideoEncoder implemetations (both Python and C++) with that of the
Encoder.The existing tests of AudioEncoder and VideoEncoder are kept, so if they pass, it means the replacement is safe. We'll remove those tests in a follow-up PR.