Fix flaky colltrace_graph_watchdog_test by removing unreliable log assertion#2716
Open
siyengar wants to merge 1 commit into
Open
Fix flaky colltrace_graph_watchdog_test by removing unreliable log assertion#2716siyengar wants to merge 1 commit into
siyengar wants to merge 1 commit into
Conversation
…sertion Summary: The `testDriverCheckCrashedWithWatchdog()` method was searching for "watchdog timeout" in NCCL_DEBUG_FILE, but the WatchdogPlugin logs that message via folly XLOG(FATAL) (stderr), not NCCL's debug file system. This caused the assertion to fail ~97% of the time. The exit code check (all workers crashed with non-zero) already validates the watchdog behavior correctly. Differential Revision: D106600065
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@siyengar has exported this pull request. If you are a Meta employee, you can view the originating Diff in D106600065. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: The
testDriverCheckCrashedWithWatchdog()method was searching for "watchdog timeout" in NCCL_DEBUG_FILE, but the WatchdogPlugin logs that message via folly XLOG(FATAL) (stderr), not NCCL's debug file system. This caused the assertion to fail ~97% of the time. The exit code check (all workers crashed with non-zero) already validates the watchdog behavior correctly.Differential Revision: D106600065