Repository navigation
Conversation
Summary: QuicWtSession drained QUIC streams eagerly into its own buffer, so QUIC released flow control credit for data the app had not read yet. The WT buffer size was also fixed at 64KB, unrelated to the QUIC window. Now each read side stream uses mvfst manual read mode, the WT buffer matches the QUIC stream window from the transport settings, and credit is released as the app consumes data. When the app stops reading, any buffered unread data counts as consumed, so its connection credit is not lost if QUIC already removed the stream. Differential Revision: D128780069
Contributor
|
@afrind has exported this pull request. If you are a Meta employee, you can view the originating Diff in D128780069. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: QuicWtSession drained QUIC streams eagerly into its own buffer, so QUIC released flow control credit for data the app had not read yet. The WT buffer size was also fixed at 64KB, unrelated to the QUIC window. Now each read side stream uses mvfst manual read mode, the WT buffer matches the QUIC stream window from the transport settings, and credit is released as the app consumes data. When the app stops reading, any buffered unread data counts as consumed, so its connection credit is not lost if QUIC already removed the stream.
Differential Revision: D128780069