Version support tags and warnings for docs - #1260
Conversation
There was a problem hiding this comment.
@alexyarosh I'm sure you'll want to wordsmith this a bit, but you might also want to think about the logic around when we should show which block. I like what I did here, but I'd defer to your judgment.
iethree
changed the title
There was a problem hiding this comment.
currently all the .scss is build in the marketing repo. this is a band-aid for some docs specific styling for now.
| --base master \ | ||
| --head "$BRANCH_NAME" \ | ||
| --title "Update version support data $DATE" \ | ||
| --body "Automated nightly update of the major version support data\`.") |
alexyarosh
left a comment
alexyarosh
left a comment
There was a problem hiding this comment.
bless you saint ryan 🙏🏼
| {% assign support = site.data.version_support[page.version] %} | ||
| {% if support.status == "unsupported" %} | ||
| <blockquote class="version-unsupported-notice"> | ||
| Version {{ page.version }} of Metabase is no longer <a class="text-purple text-underline" href="/version-support">supported</a>. Check out the <a class="text-purple text-underline" href="/docs/latest/">docs for the current stable version, Metabase {{site.docs_version}}.</a> |
There was a problem hiding this comment.
can we also bold "no longer supported"? i'd also probably make it 86px and blinking, but that's why I'm not a designer
| {% include docs-old-breadcrumbs.html %} | ||
| {% endif %} | ||
|
|
||
| {% assign support = site.data.version_support[page.version] %} |
There was a problem hiding this comment.
unrelated to this PR, but god i really wish all the pages that use this layout would just be in cold storage... we switched in v42??? or something? anything that still used this layout should be dead (if not for the couple hundred people every month that for some reason still visit these)
There was a problem hiding this comment.
we should discuss "cold storage" some more when brad is back, we've talked a little about it, but it could mean several different things, technically
| @@ -0,0 +1,77 @@ | |||
| # Builds `site.data.version_support`, a lookup table of support status keyed by | |||
There was a problem hiding this comment.
I'm just gonna say "sure, whatever" to this file 😅
3 participants
qq: should we filter this to only supported versions?