Rework Update workflows and remove master docs - #1263
Conversation
these should have been omitted, they mess up SEO and have been intentionally removed a few times
gantoreno
left a comment
There was a problem hiding this comment.
Nice! One non-blocking thing but probably worth knowing is that the clojure script still categorizes master as a publishable artifact
docs.metabase.github.io/script/update_docs_for_branchname.clj
Lines 37 to 42 in 66da972
And it even tests for it
docs.metabase.github.io/script/_test/all.clj
Lines 10 to 27 in 66da972
For correctness, going forward it might be a good idea to invert that assertion
| description: 'Major version to pull docs from metabase/metabase release branch' | ||
| required: true | ||
| type: number | ||
| default: 999 |
There was a problem hiding this comment.
Does this need a default? Is it required?
There was a problem hiding this comment.
i think it's helpful to demonstrate the format (99 vs v99 vs release-x.99.x)
There was a problem hiding this comment.
clojure script still categorizes master as a publishable artifact
I want clojure outta this repo in the medium term, but I'm gonna let @bpander do that as part of rationalizing the build process. I don't want to spend too much time tightening up a script that we plan to delete
alexyarosh
left a comment
There was a problem hiding this comment.
Ryan you are my favorite person
a. There's only one workflow now, instead of 3
b. It runs nightly on a cron with a configured LATEST_VERSION
c. It can be run manually and takes a single major version argument, rather than two branch names.
See discussion thread: https://metaboat.slack.com/archives/C0ACAG2CXHV/p1785433663417059
Best to review the second commit which is much smaller and contains all the workflow changes 66da972