Repository navigation
ci(codeql): drop the workflow; CodeQL runs as GitHub default setup - #10
Conversation
codeql.yml was disabled_manually and CodeQL now runs as GitHub's default setup, so the file, its two lock records (workflow entry and the v4.38.0 dependency, used by nothing else) and the dependabot hold on github/codeql-action are dead weight. No required status check names CodeQL (settings.yml contexts is empty); workflow-linter treats a missing codeql.yml as optional. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MF5GeeBBDF6sUzr6pZTjWV
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📜 Recent review details
📝 Summary
Merge Risk: ⚪ Minimal · up to
|
|
The red The known fix, from hyperpolymath/choreographic-types#34: pin the standards callers at Generated by Claude Code |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Add Carrot credits or activate Agent usage billing to use Autofix |
|
Please apply these changes manually.
Lines 89–95 - 'oven-sh/setup-bun@v2.2.0'
dependencies:
'Swatinem/rust-cache@6323deb102c322ba6fcbdcafc7e3dddab59af2b6':
- ref: '6323deb102c322ba6fcbdcafc7e3dddab59af2b6'
+ ref: 'v2.9.2'
commit: 'sha1-6323deb102c322ba6fcbdcafc7e3dddab59af2b6'
owner_id: 580492
repo_id: 298565987Lines 106–112 owner_id: 44036562
repo_id: 760701061
'actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9':
- ref: '55cc8345863c7cc4c66a329aec7e433d2d1c52a9'
+ ref: 'v6.1.0'
commit: 'sha1-55cc8345863c7cc4c66a329aec7e433d2d1c52a9'
owner_id: 44036562
repo_id: 215566462Lines 116–122 owner_id: 44036562
repo_id: 215566462
'actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1':
- ref: '3d3c42e5aac5ba805825da76410c181273ba90b1'
+ ref: 'v7.0.1'
commit: 'sha1-3d3c42e5aac5ba805825da76410c181273ba90b1'
owner_id: 44036562
repo_id: 197814629Lines 141–147 owner_id: 44036562
repo_id: 192626254
'actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a':
- ref: '043fb46d1a93c77aae656e7c1c64a875d1fc6a0a'
+ ref: 'v7.0.1'
commit: 'sha1-043fb46d1a93c77aae656e7c1c64a875d1fc6a0a'
owner_id: 44036562
repo_id: 192625955Lines 173–179 owner_id: 1940490
repo_id: 260749683
'editorconfig-checker/action-editorconfig-checker@51f63319f592f97930c73d9c46184d20bd206393':
- ref: '51f63319f592f97930c73d9c46184d20bd206393'
+ ref: 'v3.0.0'
commit: 'sha1-51f63319f592f97930c73d9c46184d20bd206393'
owner_id: 26415196
repo_id: 297874902Lines 183–189 owner_id: 26415196
repo_id: 297874902
'erlef/setup-beam@54075bcc5e249e4758d363f27d099f55d843f124':
- ref: '54075bcc5e249e4758d363f27d099f55d843f124'
+ ref: 'v1.24.1'
commit: 'sha1-54075bcc5e249e4758d363f27d099f55d843f124'
owner_id: 47606891
repo_id: 331103973Lines 193–204 owner_id: 47606891
repo_id: 331103973
'github/codeql-action@cdf488f595d80d6e07e03d4674febd5ab45fa938':
- ref: 'cdf488f595d80d6e07e03d4674febd5ab45fa938'
+ ref: 'v4.37.9'
commit: 'sha1-cdf488f595d80d6e07e03d4674febd5ab45fa938'
owner_id: 9919
repo_id: 259445878
'goto-bus-stop/setup-zig@abea47f85e598557f500fa1fd2ab7464fcb39406':
- ref: 'abea47f85e598557f500fa1fd2ab7464fcb39406'
+ ref: 'v2.2.1'
commit: 'sha1-abea47f85e598557f500fa1fd2ab7464fcb39406'
owner_id: 1006268
repo_id: 212984112Lines 260–266 - 'Swatinem/rust-cache@6323deb102c322ba6fcbdcafc7e3dddab59af2b6'
- 'webfactory/ssh-agent@e83874834305fe9a4a2997156cb26c5de65a8555'
'ossf/scorecard-action@2d1146689b8cda280b9bc96326124645441f03bc':
- ref: '2d1146689b8cda280b9bc96326124645441f03bc'
+ ref: 'v2.4.4'
commit: 'sha1-2d1146689b8cda280b9bc96326124645441f03bc'
owner_id: 67707773
repo_id: 421101922Lines 280–286 owner_id: 545988
repo_id: 366408409
'webfactory/ssh-agent@e83874834305fe9a4a2997156cb26c5de65a8555':
- ref: 'e83874834305fe9a4a2997156cb26c5de65a8555'
+ ref: 'v0.10.0'
commit: 'sha1-e83874834305fe9a4a2997156cb26c5de65a8555'
owner_id: 135788
repo_id: 208510314View agent analysis |
|
@coderabbitai please do not attempt CI fixes, autofix, or edits to The red Review comments are welcome; automated pushes and "fix CI" suggestions are not. Generated by Claude Code |
|
Tip For best results, initiate chat on the files or code changes. @hyperpolymath Thanks for the guidance. My earlier attribution of the CI failures to this PR was not justified. I withdraw the proposed tag edits. I will limit my participation on The standards-lock failure is being handled separately in ✏️ Learnings added
You are interacting with an AI system. |
) ## Summary GitHub's lock enforcement refuses a record for a tagged action whose `ref` repeats the SHA, both in this repo's `actions.lock` and in the called repository's lock at the pinned commit. The standards pins here (`da2c748` and `571cc734`) fail that check, so governance, secret-scanner, scorecard, hypatia-scan, mirror and rust-ci startup-fail with no jobs. Standards `75bd5994` records tags in its own lock. Same fix as choreographic-types #34. ## Changes - Repin all six standards callers (`governance`, `hypatia-scan`, `mirror`, `rust-ci`, `scorecard`, `secret-scanner`) to `75bd5994470661a099df562d6d5ad2fe744dbd66`. - Re-record the actions those workflows reach at their release tags (checkout v7.0.1, cache v6.1.0, upload-artifact v7.0.2, setup-beam v1.24.1, setup-deno v2.0.5, setup-bun v2.2.0, editorconfig-checker v3.0.0, rust-toolchain v1, setup-zig v2.2.1, rust-cache v2.9.2, ssh-agent v0.10.0, codeql-action v4.38.0, scorecard-action v2.4.4), copied from standards' own lock at that commit. - One standards record with the matching `uses:` list; the two old records are gone. Stacked on #10 (this branch includes its commit; the diff shrinks once #10 merges). ## RSR Quality Checklist ### Required - [ ] Tests pass (`just test` or equivalent) — n/a, CI config only - [x] No secrets, credentials, or `.env` files included ### As Applicable - [x] `scripts/check-lock-sync.sh` passes (in sync, transitively closed, 0 dangling edges) - [x] `scripts/check-action-pinning.js` passes (all action refs pinned) ## Testing Both lock checks above run locally. The real test is the governance, secret-scanner, scorecard, hypatia-scan, mirror and rust-ci jobs creating jobs on this PR; I have not seen that yet. ## Screenshots n/a --- _Generated by [Claude Code](https://claude.ai/code/session_01MF5GeeBBDF6sUzr6pZTjWV)_ --------- Signed-off-by: Jonathan D.A. Jewell <6759885+hyperpolymath@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…n main (#13) ## Summary `main`'s `actions.lock` has a dangling edge: the standards record's `uses:` list names `github/codeql-action@b96794f0…`, but the only top-level record is the old `…@cdf488f5…`. GitHub refuses to start runs whose lock names an unresolvable ref (zero jobs), and `scripts/check-lock-sync.sh` fails clause 3. This is what the "actions.lock is in sync" check and the GitHub Advanced Security comment on #11 flagged. Cause: #11 recorded `b96794f0` and removed `cdf488f5`; #10 (merged first) kept `cdf488f5`. Resolving the two against each other kept the old record and lost the new one. Nothing references `cdf488f5` any more (the codeql workflow was dropped in #10). ## Changes - `.github/workflows/actions.lock`: replace the unreferenced `github/codeql-action@cdf488f5…` record with `@b96794f0…` (`ref: v4.38.0`, same owner/repo ids). One record, no other change. ## RSR Quality Checklist ### Required - [x] No secrets, credentials, or `.env` files included ### As Applicable - [x] `scripts/check-lock-sync.sh` passes (in sync, transitively closed, 0 dangling edges); on `main` it fails with the dangling edge above - [x] `scripts/check-action-pinning.js` passes; keys remain C-sorted ## Testing Both scripts run locally against this branch. The real test is the governance, scan, scorecard and lock-sync jobs creating jobs and passing on this PR. --- _Generated by [Claude Code](https://claude.ai/code/session_01MF5GeeBBDF6sUzr6pZTjWV)_ Co-authored-by: Claude <noreply@anthropic.com>
Summary
codeql.ymlwasdisabled_manually, and CodeQL now runs as GitHub's default setup (enabled by the owner in repository settings). This removes the dead workflow file and everything that only existed for it.Changes
.github/workflows/codeql.yml.actions.lock: removes thecodeql.ymlworkflow entry and thegithub/codeql-action@v4.38.0dependency record. Nothing else uses that record. The@cdf488f5…record stays: the standards reusable workflow lists it..github/dependabot.yml: removes thegithub/codeql-actionhold. No workflow in this repository uses that action any more, so there is nothing to hold..github/workflows/README.adoc: the CodeQL bullet now says it is GitHub's default setup.RSR Quality Checklist
Required
just testor equivalent) — no tests apply to this changejust fmtor equivalent) — n/aunsafeblocks without// SAFETY:commentsbelieve_me,unsafeCoerce,Obj.magic,Admitted,sorry).envfiles includedAs Applicable
.machine_readable/descriptiles/STATE.a2mlupdated (if project state changed).machine_readable/descriptiles/ECOSYSTEM.a2mlupdated (if integrations changed).machine_readable/descriptiles/META.a2mlupdated (if architectural decisions changed)TOPOLOGY.mdupdated (if architecture changed)CHANGELOGor release notes updatedsrc/interface/abi/andsrc/interface/ffi/consistent)Testing
settings.ymlcontextsis empty).workflow-linter.ymltreats a missingcodeql.ymlas optional ("No CodeQL workflow found (optional)").dependabot.ymlstill parses; thegithub-actionsblock has noignore.actions.lockstill matches the workflow YAML.Screenshots
n/a
🤖 Generated with Claude Code
https://claude.ai/code/session_01MF5GeeBBDF6sUzr6pZTjWV