EPPT_3209_total_precipitable_water_assurance to master#2350
Open
mo-DavidJohnJohnston wants to merge 9 commits into
Open
EPPT_3209_total_precipitable_water_assurance to master#2350mo-DavidJohnJohnston wants to merge 9 commits into
mo-DavidJohnJohnston wants to merge 9 commits into
Conversation
MoseleyS
requested changes
Apr 2, 2026
…one. thanks to Stephen Moseley for telling me about this.
katherinetomkins-mo
previously approved these changes
Apr 7, 2026
katherinetomkins-mo
left a comment
katherinetomkins-mo
left a comment
Contributor
There was a problem hiding this comment.
Unit tests pass and tests and fix address the issue seen
MoseleyS
requested changes
Apr 7, 2026
MoseleyS
left a comment
MoseleyS
left a comment
Member
There was a problem hiding this comment.
While I think the code will work, there are some edge cases that could break it.
MoseleyS
reviewed
Apr 7, 2026
MoseleyS
reviewed
Apr 7, 2026
MoseleyS
reviewed
Apr 7, 2026
MoseleyS
reviewed
Apr 7, 2026
…one. thanks to Stephen Moseley for telling me about this.
MoseleyS
requested changes
Apr 9, 2026
robertplatt-mo
requested changes
Apr 13, 2026
robertplatt-mo
left a comment
robertplatt-mo
left a comment
Contributor
There was a problem hiding this comment.
@mo-DavidJohnJohnston Thanks this is looking good now. Still a couple of nits but it's basically there
Bring return docstring in line with Improver style
robertplatt-mo
approved these changes
Apr 14, 2026
robertplatt-mo
left a comment
robertplatt-mo
left a comment
Contributor
There was a problem hiding this comment.
You were still missing one comment on the docstrings so I went ahead and applied the suggestion rather than continue back and forth over something so nitty. Approved.
|
In order to maintain a backlog of relevant PRs, we automatically label them as stale after 60 days of inactivity. If this PR is still important to you, then please comment on this PR and the stale label will be removed. Otherwise this PR will be automatically closed in 30 days time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses JIRA ticket EPPT-3209
Fixed bug causing Total Precipitable Water numbers to be far too high.
Testing:
improver_tests/cli/test_init.py:391 (test_import_cli)
def test_import_cli():
CLA