Fix function#2389
Conversation
mo-jbeaver
left a comment
mo-jbeaver
left a comment
There was a problem hiding this comment.
I added a few small comments but overall happy with the changes.
The unit tests all ran as expected. However, the unit test should be updated to include the new variable added to the generate_roughness_length_at_sites function, checking that the pytest still runs as expected when ignore_grid_match = False and True.
Additionally, there probably should be an acceptance test that goes with these functions.
| related coordinates. | ||
|
|
||
| Args: | ||
| roughness_length: |
There was a problem hiding this comment.
| roughness_length_cube: |
| neighbour_cube: | ||
| A cube containing information about the spot data sites and | ||
| their grid point neighbours. | ||
| ignore_grid_match: |
There was a problem hiding this comment.
If adding this new variable, should the unit and acceptance tests also be updated too, to check they still run as expected.
| land_fraction = land_fraction.concatenate_cube() | ||
| land_fraction.rename("land_area_fraction") | ||
|
|
||
| return land_fraction |
There was a problem hiding this comment.
| return land_fraction | |
| return land_area_fraction |
I don't quite understand the additional line land_fraction.rename("land_area_fraction"), maybe the last line should be this?
2 participants
Addresses https://github.com/metoppv/mo-blue-team/issues/1204
Fixes an accidental line break in a docstring and ensures the resulting cube has an appropriate name.
Testing: