Ensure blend_time is consistent with forecast_reference_time when resetting#2392
Merged
Merged
Conversation
mo-jbeaver
approved these changes
Jun 9, 2026
mo-jbeaver
left a comment
mo-jbeaver
left a comment
Contributor
There was a problem hiding this comment.
Happy with the changes and tests ran successfully.
maxwhitemet
approved these changes
Jun 9, 2026
maxwhitemet
left a comment
maxwhitemet
left a comment
Contributor
There was a problem hiding this comment.
Happy with the changes made. Approved 👍
gavinevans
added a commit
to gavinevans/improver
that referenced
this pull request
Jun 9, 2026
…ion_selection_error * upstream/master: Ensure blend_time is consistent with forecast_reference_time when resetting (metoppv#2392)
gavinevans
added a commit
to gavinevans/improver
that referenced
this pull request
Jun 9, 2026
…_interpolation * upstream/master: (24 commits) houndCI removal (metoppv#2393) Add the Ensemble Copula Coupling "transformation" approach (metoppv#2303) Ensure blend_time is consistent with forecast_reference_time when resetting (metoppv#2392) Refine realization coordinate handling when clustering (metoppv#2361) Mobt1205 better accum temporal interp (metoppv#2390) Refactor pollen forecast period setting (metoppv#2385) Changes to how we do distance_to calculations (metoppv#2379) Mobt 1138 ignore git hash cli (metoppv#2388) Ensure that the SubperiodSelector plugin and CLI returns a cube with the model_id_attr, if requested. (metoppv#2386) Add option to update a scalar coordinate attribute as part of the StandardiseMetadata plugin (metoppv#2378) Allow cube-extraction to use a formatted time string (metoppv#2380) Removing a name from CONTRIBUTING.md (metoppv#2384) Support more complex forecast period filtering when training QRF (metoppv#2383) Mobt1161 precip phase decision tree (metoppv#2376) MOBT-1148 Add subperiod-selector tool (metoppv#2373) Revert "change ApplyDecisionTree categorical cube dtype from int32 to int16 (…" (metoppv#2382) change ApplyDecisionTree categorical cube dtype from int32 to int16 (metoppv#2371) Changed implementation from clipping to masking + added Unit Tests (metoppv#2366) Adding kwarg as CLI argument & updating acceptance tests. (metoppv#2377) Refactor Pollen index for daily and hourly to single plugin (metoppv#2372) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #2361, #2364, https://github.com/metoppv/mo-blue-team/issues/783
Description
This PR makes a minor edit to the reset_forecast_reference_time_and_period function, so that the "blend_time" coordinate is also handled, if it's present on the input cube, so that
forecast_reference_timeandblend_timeremain consistent.Testing: