BUG: correct save perms to 644#2402
Merged
Merged
Conversation
jamesda70
approved these changes
Jun 19, 2026
jamesda70
left a comment
jamesda70
left a comment
There was a problem hiding this comment.
Looks sensible to me.
As an aside have you looked at using pathlib instead of os, for path related operations?
Contributor
Author
Typically, elsewhere, yes. These changes to improver save right now are minimal change bugfixes to what's already there to get the operational release across the line. Cheers |
MoseleyS
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2397 resulted in files that are only read/writable by the user (permissions "600") rather than including read-permissions for group and all too (permissions "644"). This PR ensures the permissions are as intended.