Skip to content

#1 use proxied subscriber for duplicate subscriber check in all cases #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
void256 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#1 use proxied subscriber for duplicate subscriber check in all cases #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<name>EventBus</name>
<packaging>jar</packaging>
<description>A simple but powerful publish-subscribe API that is based on class semantics and/or string (topic) matching.</description>
<version>1.4</version>
<version>1.4.1-SNAPSHOT</version>
<url>http://www.eventbus.org</url>
<scm>
<url>https://eventbus.dev.java.net/source/browse/eventbus/</url>
Expand Down
4 changes: 1 addition & 3 deletions src/org/bushe/swing/event/ThreadSafeEventService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,9 +630,7 @@ protected boolean subscribe(final Object classTopicOrPatternWrapper, final Map<O
hasEverUsedPrioritized = true;
}
isWeakProxySubscriber = proxySubscriber.getReferenceStrength() == ReferenceStrength.WEAK;
if (isWeakProxySubscriber) {
realSubscriber = ((ProxySubscriber) subscriber).getProxiedSubscriber();
}
realSubscriber = ((ProxySubscriber) subscriber).getProxiedSubscriber();
}
if (isWeakRef && isWeakProxySubscriber) {
throw new IllegalArgumentException("ProxySubscribers should always be subscribed strongly.");
Expand Down