test(coreApiWebdavUploadTUS): expect 400 for invalid TUS upload names#1
Open
michaelstingl wants to merge 1 commit into
Open
test(coreApiWebdavUploadTUS): expect 400 for invalid TUS upload names#1michaelstingl wants to merge 1 commit into
michaelstingl wants to merge 1 commit into
Conversation
opencloud-eu/reva#655 changes the TUS create response for an invalid name from 412 to 400. Update the invalid-name scenario to match. Each example now carries its own expected status in an <http-status-code> column. Names that fail ValidateName expect 400. The three folder/file rows stay 412: filename() applies path.Base first, so "folder/file" becomes the valid leaf "file" and never reaches the changed branch. lowLevelCreationExtension.feature is unchanged; its missing-Upload-Length case still returns 412. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Label error. Requires at least 1 of: Type:Bug, Type:Enhancement, Type:Feature, Type:Breaking-Change, Type:Test, Type:Documentation, Type:Maintenance, Type:Security, Type:Dependencies, Type:DevOps, dependencies. Found: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch is rhafer's
reva-655(the branch behind the test PR, which bumps reva to the fork that carries the new400behavior), plus one commit: theuploadFile.featureupdate for that change. It lives in a fork as a standalone diff to view or apply, not a pull request againstmain.The reva change makes a TUS create with an invalid name return
400instead of412. The scenario splits per example with an<http-status-code>column:ValidateNameexpects400(12 of the 15 examples)folder/filerows stay412:filename()appliespath.Basefirst, sofolder/filebecomes the valid leaffile, passesValidateName, and never reaches the changed branchlowLevelCreationExtension.featureis unchanged; its missing-Upload-Lengthcase still returns412.The per-example outcome comes from the api-integration run on the reva PR.
🤖 drafted with Claude Code, reviewed before submitting.