Skip to content

add Crest study dataset#111

Merged
TuomasBorman merged 9 commits into
develfrom
new_demo
Sep 22, 2025
Merged

add Crest study dataset#111
TuomasBorman merged 9 commits into
develfrom
new_demo

Conversation

@0xMuluh

@0xMuluh 0xMuluh commented Apr 20, 2025

Copy link
Copy Markdown
Contributor

ping: #110

Signed-off-by: Daena Rys <rysdaena8@gmail.com>
@0xMuluh 0xMuluh requested a review from antagomir April 20, 2025 13:26
Comment thread R/miaTime.R
Comment thread R/miaTime.R Outdated
Comment thread R/miaTime.R Outdated
Comment thread R/miaTime.R
Comment thread R/miaTime.R Outdated
0xMuluh added 2 commits April 24, 2025 14:45
Signed-off-by: Daena Rys <rysdaena8@gmail.com>
Signed-off-by: Daena Rys <rysdaena8@gmail.com>
@0xMuluh 0xMuluh requested a review from TuomasBorman June 5, 2025 06:10
@antagomir

Copy link
Copy Markdown
Member

There are unresolved comments. Can you respond, or close if they are clear? Then we can assess merge.

@antagomir

Copy link
Copy Markdown
Member

Some checks also failing.

@0xMuluh

0xMuluh commented Jun 5, 2025

Copy link
Copy Markdown
Contributor Author

Some checks also failing.

The fail is unrelated. Has to do with gha mac

@antagomir antagomir left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good!

@antagomir

Copy link
Copy Markdown
Member

Ok to merge.

@TuomasBorman TuomasBorman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, final things. Sorry for the delay

  1. Is there R script available that produces this data? You could add it.

  2. TRUE/FALSE values in colData are characters. Convert to logical.

  3. Remove extra data. There are additional assays in many experiments. Moreover, there is shannon index in colData. The data could include only the "raw" data to reduce the memory size and also because these results can be calculated from raw data.

  4. Convert sample name format from "Sample-1" to "sample_1" (Underscore is usually safer)

  5. rownames(altExp(tse, 4)) could then be formatted similarly to sample names, i.e., "feature_1" as they are generated by us.

@TuomasBorman TuomasBorman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TuomasBorman TuomasBorman merged commit 3f90283 into devel Sep 22, 2025
3 checks passed
@TuomasBorman TuomasBorman deleted the new_demo branch September 22, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants