Stop Android system bars overlapping the app UI#906
Merged
Conversation
The overlap occurs below Chromium 140. The safe area community plugin addresses this, however, our keyboard intervention that keeps the UI from resizing when the keyboard is opened stops the plugin from working. We have moved the logic from the plugin to MainActivity.java as phase 1. In phase 2, we will remove the plugin and implement the system bar styling light/dark via other means.
|
Preview build will be at |
Author
|
Tested on Android 12 Chromium <140.
Tested on Android 15 Chromium > 140.
|
microbit-matt-hillsdon
approved these changes
Jun 10, 2026
microbit-matt-hillsdon
left a comment
microbit-matt-hillsdon
left a comment
There was a problem hiding this comment.
Makes sense, seems logical. Relying on your screenshots rather than retesting it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #897
The overlap occurs for Chromium versions below 140. The safe area community plugin addresses this, however, our
setOnApplyWindowInsetsListenerthat keeps the UI from resizing when the keyboard is opened stops the plugin from working. This is because oursetOnApplyWindowInsetsListeneroverwrites the plugin's.To address this, the safe area community plugin has been dropped and the fix for the safe area and the system bar styling have been moved to MainActivity.java. Now we only have one
setOnApplyWindowInsetsListenerthat applies the fix for safe area and prevents UI from resizing when the keyboard is opened.