Fido: Fix request with FidoAppIdExtension#3544
Open
p1gp1g wants to merge 1 commit into
Open
Conversation
The JSON key is `appid`, and if it was present we were trying to get `appId` which always failed with an exception "No value for appId"
mar-v-in
approved these changes
Jun 8, 2026
mar-v-in
reviewed
Jun 8, 2026
| @@ -182,7 +182,7 @@ fun JSONObject.parseTokenBinding() = when (TokenBindingStatus.fromString(getStri | |||
| fun JSONObject.parseAuthenticationExtensions(): AuthenticationExtensions { | |||
| val builder = AuthenticationExtensions.Builder() | |||
| if (has("fidoAppIdExtension")) builder.setFido2Extension(FidoAppIdExtension(getJSONObject("fidoAppIdExtension").getString("appId"))) | |||
Member
There was a problem hiding this comment.
Suggested change
| if (has("fidoAppIdExtension")) builder.setFido2Extension(FidoAppIdExtension(getJSONObject("fidoAppIdExtension").getString("appId"))) | |
| if (has("fidoAppIdExtension")) builder.setFido2Extension(FidoAppIdExtension(getJSONObject("fidoAppIdExtension").getString("appid"))) |
This one also needs to be fixed.
Contributor
Author
There was a problem hiding this comment.
I didn't find any doc regarding fidoAppIdExtension, do you have one?
Also, I think it may be worth catching issues here, because we don't check if fidoAppIdExtension object has a appid field - and we can't be sure there isn't any type error
Suggested change
| if (has("fidoAppIdExtension")) builder.setFido2Extension(FidoAppIdExtension(getJSONObject("fidoAppIdExtension").getString("appId"))) | |
| if (has("fidoAppIdExtension")) runCatching { | |
| builder.setFido2Extension(FidoAppIdExtension(getJSONObject("fidoAppIdExtension").getString("appid"))) | |
| } |
Note that we can probably do a runCatching for the other appid field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JSON key is
appid, and if it was present we were trying to getappIdwhich always failed with an exception "No value for appId"It caused a crash with Gitlab for example