Fido: Fix credential assertion with Chromium-based browsers (add missing public key)#3545
Open
p1gp1g wants to merge 2 commits into
Open
Fido: Fix credential assertion with Chromium-based browsers (add missing public key)#3545p1gp1g wants to merge 2 commits into
p1gp1g wants to merge 2 commits into
Conversation
We were maintaining 2 different list of algorithmInt to Algorithm which led to missing alg (-8). By using EC2Algorithm and RSAAlgorithm enums directly we avoid further missing algs.
The parameter must be retrieved using the NamedParameterSpec cf. https://docs.oracle.com/en/java/javase/25/docs/specs/security/standard-names.html#namedparameterspec
p1gp1g
changed the title
p1gp1g
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That fixes the publicKey field from the authenticationAssertion (when the user makes a credential with FIDO) because:
-8(Ed25519) => we never had that AlgorithmChromium based browsers need that publicKey to accept registrations: