Skip to content

fix(fido): allow valid maximum domainId 65535 in extensions#3548

Open
GN998 wants to merge 1 commit into
microg:masterfrom
LibreFido:master
Open

fix(fido): allow valid maximum domainId 65535 in extensions#3548
GN998 wants to merge 1 commit into
microg:masterfrom
LibreFido:master

Conversation

@GN998

@GN998 GN998 commented Jun 9, 2026

Copy link
Copy Markdown

feat: add support for 256-65535 domain index range

@GN998 GN998 marked this pull request as ready for review June 9, 2026 15:13
@p1gp1g

p1gp1g commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

For the details:

https://fidoalliance.org/specs/fido-v2.3-rd-20251023/fido-client-to-authenticator-protocol-v2.3-rd-20251023.html#hybrid-websocket-channel

The encoded tunnel service identifier is a uint16. Values zero through 255 are assigned, and values >= 256 are translated into a domain name by hashing. A “cable” label is prepended to hashed domains to allow for use of CNAME records.

The domain name by hashing is implemented, but it doesn't work because of the assertion.

@GN998: If I can give an advise, maybe you can rename the PR to start with FIDO: [...] or fix(fido) so it can easily be sorted 👍

@GN998 GN998 changed the title fix: allow valid maximum domainId 65535 in extensions fix(fido): allow valid maximum domainId 65535 in extensions Jun 10, 2026
@GN998

GN998 commented Jun 10, 2026

Copy link
Copy Markdown
Author

Thanks for the suggestion.
Also, I'd like to share that my initial approach was:
require(domainId in 256..65535)
@p1gp1g

@p1gp1g

p1gp1g commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Also, I'd like to share that my initial approach was:
require(domainId in 256..65535)

Indeed, that's what it should be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants