Skip to content

GP Migration - Prevent date issues with new No Series for Sales/Purchase Codes #30022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jaymckinney-enavate wants to merge 1 commit into from
+3 −3
Closed

GP Migration - Prevent date issues with new No Series for Sales/Purchase Codes #30022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Apps/W1/HybridGP/app/src/Migration/Customers/GPCustomerMigrator.codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,7 @@ codeunit 4018 "GP Customer Migrator"
DimSetID: Integer;
begin
if GPAccount."Standard Sales Code" = '' then begin
GPAccount."Standard Sales Code" := CopyStr(NoSeries.GetNextNo(NoSeriesStandardSalesCodeTok), 1, MaxStrLen(GPAccount."Standard Sales Code"));
GPAccount."Standard Sales Code" := CopyStr(NoSeries.GetNextNo(NoSeriesStandardSalesCodeTok, Today()), 1, MaxStrLen(GPAccount."Standard Sales Code"));

StandardSalesCode.Validate("Code", GPAccount."Standard Sales Code");
StandardSalesCode.Validate(Description, CopyStr(HelperFunctions.GenerateStandardCodeDescriptionFromAccount(GPAccount), 1, MaxStrLen(StandardSalesCode.Description)));
Expand Down
2 changes: 1 addition & 1 deletion Apps/W1/HybridGP/app/src/Migration/Support/HelperFunctions.codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,7 +643,7 @@ codeunit 4037 "Helper Functions"

NoSeriesLine.Validate("Series Code", NoSeriesCode);
NoSeriesLine.Validate("Starting No.", StartingNo);
NoSeriesLine.Validate("Starting Date", Today());
NoSeriesLine.Validate("Starting Date", 0D);
NoSeriesLine.Validate("Increment-by No.", 1);
NoSeriesLine.Validate(Implementation, "No. Series Implementation"::Normal);
NoSeriesLine.Insert(true);
Expand Down
2 changes: 1 addition & 1 deletion Apps/W1/HybridGP/app/src/Migration/Vendors/GPVendorMigrator.codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -637,7 +637,7 @@ codeunit 4022 "GP Vendor Migrator"
DimSetID: Integer;
begin
if GPAccount."Standard Purchase Code" = '' then begin
GPAccount."Standard Purchase Code" := CopyStr(NoSeries.GetNextNo(NoSeriesStandardPurchaseCodeTok), 1, MaxStrLen(GPAccount."Standard Purchase Code"));
GPAccount."Standard Purchase Code" := CopyStr(NoSeries.GetNextNo(NoSeriesStandardPurchaseCodeTok, Today()), 1, MaxStrLen(GPAccount."Standard Purchase Code"));

StandardPurchaseCode.Validate("Code", GPAccount."Standard Purchase Code");
StandardPurchaseCode.Validate(Description, CopyStr(HelperFunctions.GenerateStandardCodeDescriptionFromAccount(GPAccount), 1, MaxStrLen(StandardPurchaseCode.Description)));
Expand Down
Loading