salvage: fix inverse scale when writing binvox meshes (credit @sotpapathe #4710)#9792
Open
Bartok9 wants to merge 1 commit into
Open
salvage: fix inverse scale when writing binvox meshes (credit @sotpapathe #4710)#9792Bartok9 wants to merge 1 commit into
Bartok9 wants to merge 1 commit into
Conversation
The binvox writer emitted scale as 1/x_size; the binvox format expects the unit edge length, so export inverted extents. Salvage of @sotpapathe microsoft#4710 onto current main. Credit: @sotpapathe (microsoft#4710) AI-assisted; human-reviewed.
Bartok9
force-pushed
the
aerial/salvage-binvox-scale-4710-20260719
branch
from
July 19, 2026 09:22
dd905cd to
dc6c1d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage line
salvage of #4710 by @sotpapathe — full credit to the original author.
Problem
WorldSimApi::createVoxelGridwrote the binvoxscalefield as1.0f / x_size. In the binvox header,scaleis the unit length of the grid’s edge along the first dimension, not its reciprocal. Downstream tools then reconstructed inverted/wrong physical extents.Change
scale << x_size(same as original PR intent)main(single-line + comment)Why not just bump the old PR
Original remains open/MERGEABLE but sat idle since 2022-09; this re-lands the fix with active attribution so maintainers have a fresh head.
Verification
Unreal/Plugins/AirSim/Source/WorldSimApi.cppAI-assisted; human-reviewed. Please keep credit with @sotpapathe.