[Shim] Clean up logging folder#3046
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes the entire LOGGING folder structure as part of a cleanup operation. The PR deletes test projects, source code, shared utilities, and configuration files related to various logging adapters including TraceListener, Log4NetAppender, ILogger, EventSourceListener, EtwCollector, and DiagnosticSourceListener.
Key Changes:
- Complete removal of all logging-related test projects and their test files
- Deletion of all source code for logging adapters
- Removal of XDT transformation files for configuration management
- Removal of shared test and source code utilities
- One minor modification to
NLogTarget.csprojto remove an import reference to the deleted CommonShared project
Reviewed changes
Copilot reviewed 108 out of 108 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| All test project files (.csproj, .cs, .xml) | Complete removal of test infrastructure for various logging adapters |
| All source files (.cs, .csproj) | Deletion of logging adapter implementations |
| XDT configuration files (.xdt) | Removal of configuration transformation files |
| Shared project files (.projitems, .shproj) | Deletion of shared code and test utilities |
| LOGGING/src/NLogTarget/NLogTarget.csproj | Removed import statement referencing the deleted CommonShared project |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
harsimar
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.