Skip to content

Make Copilot PR review CLI timeout configurable #8159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WaelAbuSeada wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −2
Open

Make Copilot PR review CLI timeout configurable #8159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
99f36fc
Make Copilot CLI timeout configurable in PR review workflow
WaelAbuSeada May 13, 2026
f325d67
Merge remote-tracking branch 'origin/main' into fix/copilot-cli-timeo…
Copilot May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/CopilotPRReviewRunner.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ jobs:
MAX_FINDINGS_PER_DOMAIN: ${{ vars.COPILOT_REVIEW_MAX_FINDINGS_PER_DOMAIN || '25' }}
COPILOT_REVIEW_FAIL_ON_PARSE_ERROR: ${{ vars.COPILOT_REVIEW_FAIL_ON_PARSE_ERROR || 'true' }}
COPILOT_REVIEW_EMBED_DIFF: ${{ vars.COPILOT_REVIEW_EMBED_DIFF || 'false' }}
COPILOT_REVIEW_CLI_TIMEOUT_MINUTES: ${{ vars.COPILOT_REVIEW_CLI_TIMEOUT_MINUTES || '30' }}
COPILOT_REVIEW_AGENT_LABEL: ${{ vars.COPILOT_REVIEW_AGENT_LABEL || 'copilot-pr-review' }}
COPILOT_REVIEW_AGENT_RELEASE_DATE: ${{ vars.COPILOT_REVIEW_AGENT_RELEASE_DATE }}
COPILOT_REVIEW_AGENT_RELEASE_VERSION: ${{ vars.COPILOT_REVIEW_AGENT_RELEASE_VERSION || '0' }}
Expand Down
11 changes: 9 additions & 2 deletions tools/Code Review/scripts/Invoke-CopilotPRReview.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
COPILOT_MODEL – explicit model name passed to copilot CLI
MINIMUM_SEVERITY – Critical | High | Medium | Low (default: Medium)
MAX_FINDINGS_PER_DOMAIN – cap on posted findings (default: 25)
COPILOT_REVIEW_CLI_TIMEOUT_MINUTES – Copilot CLI timeout in minutes (default: 30)
COMMENT_DELAY_SECONDS – sleep between API posts (default: 0.5)
REVIEW_OUTPUT_DIR – output folder for raw + parsed review files
#>
Expand All @@ -46,6 +47,7 @@ $CopilotModel = ($env:COPILOT_MODEL ?? '').Trim()
$MinimumSeverity = $env:MINIMUM_SEVERITY ?? 'Medium'
$MaxContextSize = [int]($env:MAX_REVIEW_CONTEXT_SIZE ?? 150000)
$MaxFindings = [int]($env:MAX_FINDINGS_PER_DOMAIN ?? 25)
$CopilotCliTimeoutMinutes = [int]($env:COPILOT_REVIEW_CLI_TIMEOUT_MINUTES ?? 30)
$FailOnParseErrorRaw = (($env:COPILOT_REVIEW_FAIL_ON_PARSE_ERROR ?? 'true') + '').Trim().ToLowerInvariant()
$FailOnParseError = @('1','true','yes','on') -contains $FailOnParseErrorRaw
$EmbedDiffInPromptRaw = (($env:COPILOT_REVIEW_EMBED_DIFF ?? 'false') + '').Trim().ToLowerInvariant()
Expand Down Expand Up @@ -98,6 +100,10 @@ function Assert-Config {
if (-not (Get-Command copilot -ErrorAction SilentlyContinue)) {
throw 'Copilot CLI not found in PATH. Install @github/copilot before running this script.'
}

if ($CopilotCliTimeoutMinutes -lt 1) {
throw "COPILOT_REVIEW_CLI_TIMEOUT_MINUTES must be a positive integer. Actual: $CopilotCliTimeoutMinutes"
}
}

# ---------------------------------------------------------------------------
Expand Down Expand Up @@ -476,10 +482,11 @@ function Invoke-CopilotCli {
$stdoutTask = $process.StandardOutput.ReadToEndAsync()
$stderrTask = $process.StandardError.ReadToEndAsync()

$completed = $process.WaitForExit(1200000) # 20 min timeout in ms
$timeoutMs = $CopilotCliTimeoutMinutes * 60 * 1000
$completed = $process.WaitForExit($timeoutMs)
if (-not $completed) {
try { $process.Kill($true) } catch { Write-Error "Failed to terminate timed out Copilot CLI process: $($_.Exception.Message)" }
throw 'Copilot CLI timed out after 20 minutes.'
throw "Copilot CLI timed out after $CopilotCliTimeoutMinutes minutes."
}

[System.Threading.Tasks.Task]::WaitAll(@($stdoutTask, $stderrTask))
Expand Down