Skip to content

Fix DeployToReferenceDocumentation#8921

Open
spetersenms wants to merge 9 commits into
mainfrom
spetersen/FixReferenceDocumentationFlow
Open

Fix DeployToReferenceDocumentation#8921
spetersenms wants to merge 9 commits into
mainfrom
spetersen/FixReferenceDocumentationFlow

Conversation

@spetersenms

@spetersenms spetersenms commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

What & why

The reference documentation flow (both stand-alone and in CICD) was broken due to duplicate app ids caused by the localization of layers.
Specifically the DetermineArtifactUrl step fails when running with no specific project project=".".

The fix was to add a conditional setting, that when no project is selected, we use the appFolders setting to point to any random app.

Working run here: https://github.com/microsoft/BCApps/actions/runs/28441725835

AB#612711

  • I read the full diff and it contains only changes I intended.
  • I built the affected app(s) locally with no new analyzer warnings.
  • I ran the change in Business Central and confirmed it behaves as expected.
  • I added or updated tests for the new behavior, or explained below why none are needed.

What I tested and the outcome (required — be specific: scenarios, commands, screenshots for UI changes)

Risk & compatibility

spetersenms and others added 6 commits June 30, 2026 13:21
…s used in order to unblock ReferenceDocumentationFlow
Test projects (build/projects/Test Apps *) contain no real product apps
to document, so exclude them from the ALDoc reference documentation build.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@spetersenms spetersenms requested review from a team June 30, 2026 12:05
@github-actions github-actions Bot added the Build: Automation Workflows and other setup in .github folder label Jun 30, 2026
@github-actions

github-actions Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Copilot PR Review

Iteration 3 · Outcome: not-applicable

The diff contains only .github/AL-Go-Settings.json (AL-Go pipeline/build configuration: a new project's appFolders mapping, ALDoc continuousDeployment flag, and includeProjects list). No AL source files (.al) were changed, so none of the six AL review domains (performance, security, privacy, upgrade, style, UI) have any applicable content to evaluate.

Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630

No findings were posted for this iteration.

Orchestrator pre-filter (13 file(s) excluded)

  • layer-disabled (knowledge) : 13 file(s)

Findings produced by the Copilot CLI agent against BCQuality at 822cae1b2771ac25f665f73369f69093bd4fd630. Reply 👎 on any inline comment to flag false positives.

@github-actions

Copy link
Copy Markdown
Contributor

Issue #612711 is not valid. Please make sure you link an issue that exists, is open and is approved.

@github-actions github-actions Bot added this to the Version 29.0 milestone Jun 30, 2026
spetersenms and others added 3 commits July 1, 2026 11:04
Set ALDoc.includeProjects to build_projects_Apps W1 so only the W1 base
apps are documented. Documenting all country projects is not viable:
the same apps are recompiled per country, so aldoc merges same-named apps
(e.g. Base Application) into a single entry with no country provenance,
and passing all ~2600 apps to 'aldoc init --targetpackageslist' exceeds
the Windows command-line length limit.

includeProjects acts as a whitelist, making the previous
'build_projects_Test Apps *' exclusion redundant, so revert it. The
conditional appFolders setting is retained: it is required to unblock
AnalyzeRepo/DetermineArtifactUrl and is unrelated to project selection.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Build: Automation Workflows and other setup in .github folder

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant