Skip to content

Add-IgnoreCommit-in-GenJnlPostLine-codeunit #8925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alexander-Ya wants to merge 1 commit into
base: main
Choose a base branch
from
+732 −33
Open

Add-IgnoreCommit-in-GenJnlPostLine-codeunit #8925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 46 additions & 3 deletions src/Layers/APAC/BaseApp/Finance/GeneralLedger/Posting/GenJnlPostLine.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ codeunit 12 "Gen. Jnl.-Post Line"
SequenceNoMgt.ClearSequenceNoCheck();

GenJnlLine.Copy(GenJnlLine2);
Code(GenJnlLine, true);
Post(GenJnlLine, true);
OnAfterRunWithCheck(GenJnlLine);
GenJnlLine2 := GenJnlLine;
exit(GLEntryNo);
Expand All @@ -259,13 +259,51 @@ codeunit 12 "Gen. Jnl.-Post Line"
exit(GLEntryNo);

GenJnlLine.Copy(GenJnlLine2);
Code(GenJnlLine, false);
Post(GenJnlLine, false);
OnAfterRunWithoutCheck(GenJnlLine);
GenJnlLine2 := GenJnlLine;
exit(GLEntryNo);
end;

local procedure "Code"(var GenJnlLine: Record "Gen. Journal Line"; CheckLine: Boolean)
/// <summary>
/// A wrapper procedure to delegate to either a procedure that allows commit or a procedure that ignores commit.
/// By default, commits are suppressed during the critical posting window to prevent duplicate-key races
/// on G/L Entry (table 17). Subscribers can opt out by setting IgnoreCommit to false via OnSetCommitBehavior.
/// </summary>
/// <param name="GenJnlLine">The general journal line that is being posted.</param>
/// <param name="CheckLine">Indicates whether to check the lines before posting.</param>
local procedure Post(var GenJnlLine: Record "Gen. Journal Line"; CheckLine: Boolean)
var
IgnoreCommit: Boolean;
begin
IgnoreCommit := true;
OnSetCommitBehavior(IgnoreCommit);

if IgnoreCommit then
PostLineCommitBehaviorIgnore(GenJnlLine, CheckLine)
else
PostLine(GenJnlLine, CheckLine);
end;

/// <summary>
/// A wrapper procedure to delegate to PostLines in order to ignore commits.
/// While this procedure is on the call stack, the platform turns every Commit() into a no-op,
/// preventing intermittent duplicate-key errors on G/L Entry (table 17).
/// </summary>
/// <param name="GenJnlLine">The general journal line that is being posted.</param>
/// <param name="CheckLine">Indicates whether to check the line before posting.</param>
[CommitBehavior(CommitBehavior::Ignore)]
local procedure PostLineCommitBehaviorIgnore(var GenJnlLine: Record "Gen. Journal Line"; CheckLine: Boolean)
begin
PostLine(GenJnlLine, CheckLine);
end;

/// <summary>
/// Posting procedure for general journal lines
/// </summary>
/// <param name="GenJnlLine">The general journal line that is being posted.</param>
/// <param name="CheckLine">Indicates whether to check the line before posting.</param>
local procedure PostLine(var GenJnlLine: Record "Gen. Journal Line"; CheckLine: Boolean)
var
xGLEntryNo: Integer;
Balancing: Boolean;
Expand Down Expand Up @@ -13545,4 +13583,9 @@ codeunit 12 "Gen. Jnl.-Post Line"
local procedure OnPostUnapplyOnBeforeInsertTempVATEntry(var VATEntry: Record "VAT Entry"; var UnapplyVATEntries: Boolean)
begin
end;

[IntegrationEvent(false, false)]
local procedure OnSetCommitBehavior(var IgnoreCommit: Boolean)
begin
end;
}
49 changes: 46 additions & 3 deletions src/Layers/BE/BaseApp/Finance/GeneralLedger/Posting/GenJnlPostLine.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ codeunit 12 "Gen. Jnl.-Post Line"
SequenceNoMgt.ClearSequenceNoCheck();

GenJnlLine.Copy(GenJnlLine2);
Code(GenJnlLine, true);
Post(GenJnlLine, true);
OnAfterRunWithCheck(GenJnlLine);
GenJnlLine2 := GenJnlLine;
exit(GLEntryNo);
Expand All @@ -241,13 +241,51 @@ codeunit 12 "Gen. Jnl.-Post Line"
exit(GLEntryNo);

GenJnlLine.Copy(GenJnlLine2);
Code(GenJnlLine, false);
Post(GenJnlLine, false);
OnAfterRunWithoutCheck(GenJnlLine);
GenJnlLine2 := GenJnlLine;
exit(GLEntryNo);
end;

local procedure "Code"(var GenJnlLine: Record "Gen. Journal Line"; CheckLine: Boolean)
/// <summary>
/// A wrapper procedure to delegate to either a procedure that allows commit or a procedure that ignores commit.
/// By default, commits are suppressed during the critical posting window to prevent duplicate-key races
/// on G/L Entry (table 17). Subscribers can opt out by setting IgnoreCommit to false via OnSetCommitBehavior.
/// </summary>
/// <param name="GenJnlLine">The general journal line that is being posted.</param>
/// <param name="CheckLine">Indicates whether to check the lines before posting.</param>
local procedure Post(var GenJnlLine: Record "Gen. Journal Line"; CheckLine: Boolean)
var
IgnoreCommit: Boolean;
begin
IgnoreCommit := true;
OnSetCommitBehavior(IgnoreCommit);

if IgnoreCommit then
PostLineCommitBehaviorIgnore(GenJnlLine, CheckLine)
else
PostLine(GenJnlLine, CheckLine);
end;

/// <summary>
/// A wrapper procedure to delegate to PostLines in order to ignore commits.
/// While this procedure is on the call stack, the platform turns every Commit() into a no-op,
/// preventing intermittent duplicate-key errors on G/L Entry (table 17).
/// </summary>
/// <param name="GenJnlLine">The general journal line that is being posted.</param>
/// <param name="CheckLine">Indicates whether to check the line before posting.</param>
[CommitBehavior(CommitBehavior::Ignore)]
local procedure PostLineCommitBehaviorIgnore(var GenJnlLine: Record "Gen. Journal Line"; CheckLine: Boolean)
begin
PostLine(GenJnlLine, CheckLine);
end;

/// <summary>
/// Posting procedure for general journal lines
/// </summary>
/// <param name="GenJnlLine">The general journal line that is being posted.</param>
/// <param name="CheckLine">Indicates whether to check the line before posting.</param>
local procedure PostLine(var GenJnlLine: Record "Gen. Journal Line"; CheckLine: Boolean)
var
xGLEntryNo: Integer;
Balancing: Boolean;
Expand Down Expand Up @@ -11146,4 +11184,9 @@ codeunit 12 "Gen. Jnl.-Post Line"
local procedure OnPostUnapplyOnBeforeInsertTempVATEntry(var VATEntry: Record "VAT Entry"; var UnapplyVATEntries: Boolean)
begin
end;

[IntegrationEvent(false, false)]
local procedure OnSetCommitBehavior(var IgnoreCommit: Boolean)
begin
end;
}
49 changes: 46 additions & 3 deletions src/Layers/CH/BaseApp/Finance/GeneralLedger/Posting/GenJnlPostLine.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ codeunit 12 "Gen. Jnl.-Post Line"
SequenceNoMgt.ClearSequenceNoCheck();

GenJnlLine.Copy(GenJnlLine2);
Code(GenJnlLine, true);
Post(GenJnlLine, true);
OnAfterRunWithCheck(GenJnlLine);
GenJnlLine2 := GenJnlLine;
exit(GLEntryNo);
Expand All @@ -242,13 +242,51 @@ codeunit 12 "Gen. Jnl.-Post Line"
exit(GLEntryNo);

GenJnlLine.Copy(GenJnlLine2);
Code(GenJnlLine, false);
Post(GenJnlLine, false);
OnAfterRunWithoutCheck(GenJnlLine);
GenJnlLine2 := GenJnlLine;
exit(GLEntryNo);
end;

local procedure "Code"(var GenJnlLine: Record "Gen. Journal Line"; CheckLine: Boolean)
/// <summary>
/// A wrapper procedure to delegate to either a procedure that allows commit or a procedure that ignores commit.
/// By default, commits are suppressed during the critical posting window to prevent duplicate-key races
/// on G/L Entry (table 17). Subscribers can opt out by setting IgnoreCommit to false via OnSetCommitBehavior.
/// </summary>
/// <param name="GenJnlLine">The general journal line that is being posted.</param>
/// <param name="CheckLine">Indicates whether to check the lines before posting.</param>
local procedure Post(var GenJnlLine: Record "Gen. Journal Line"; CheckLine: Boolean)
var
IgnoreCommit: Boolean;
begin
IgnoreCommit := true;
OnSetCommitBehavior(IgnoreCommit);

if IgnoreCommit then
PostLineCommitBehaviorIgnore(GenJnlLine, CheckLine)
else
PostLine(GenJnlLine, CheckLine);
end;

/// <summary>
/// A wrapper procedure to delegate to PostLines in order to ignore commits.
/// While this procedure is on the call stack, the platform turns every Commit() into a no-op,
/// preventing intermittent duplicate-key errors on G/L Entry (table 17).
/// </summary>
/// <param name="GenJnlLine">The general journal line that is being posted.</param>
/// <param name="CheckLine">Indicates whether to check the line before posting.</param>
[CommitBehavior(CommitBehavior::Ignore)]
local procedure PostLineCommitBehaviorIgnore(var GenJnlLine: Record "Gen. Journal Line"; CheckLine: Boolean)
begin
PostLine(GenJnlLine, CheckLine);
end;

/// <summary>
/// Posting procedure for general journal lines
/// </summary>
/// <param name="GenJnlLine">The general journal line that is being posted.</param>
/// <param name="CheckLine">Indicates whether to check the line before posting.</param>
local procedure PostLine(var GenJnlLine: Record "Gen. Journal Line"; CheckLine: Boolean)
var
xGLEntryNo: Integer;
Balancing: Boolean;
Expand Down Expand Up @@ -11168,4 +11206,9 @@ codeunit 12 "Gen. Jnl.-Post Line"
local procedure OnPostUnapplyOnBeforeInsertTempVATEntry(var VATEntry: Record "VAT Entry"; var UnapplyVATEntries: Boolean)
begin
end;

[IntegrationEvent(false, false)]
local procedure OnSetCommitBehavior(var IgnoreCommit: Boolean)
begin
end;
}
49 changes: 46 additions & 3 deletions src/Layers/ES/BaseApp/Finance/GeneralLedger/Posting/GenJnlPostLine.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ codeunit 12 "Gen. Jnl.-Post Line"
exit(GLEntryNo);

GenJnlLine.Copy(GenJnlLine2);
Code(GenJnlLine, true);
Post(GenJnlLine, true);
OnAfterRunWithCheck(GenJnlLine);
GenJnlLine2 := GenJnlLine;
exit(GLEntryNo);
Expand All @@ -281,13 +281,51 @@ codeunit 12 "Gen. Jnl.-Post Line"
exit(GLEntryNo);

GenJnlLine.Copy(GenJnlLine2);
Code(GenJnlLine, false);
Post(GenJnlLine, false);
OnAfterRunWithoutCheck(GenJnlLine);
GenJnlLine2 := GenJnlLine;
exit(GLEntryNo);
end;

local procedure "Code"(var GenJnlLine: Record "Gen. Journal Line"; CheckLine: Boolean)
/// <summary>
/// A wrapper procedure to delegate to either a procedure that allows commit or a procedure that ignores commit.
/// By default, commits are suppressed during the critical posting window to prevent duplicate-key races
/// on G/L Entry (table 17). Subscribers can opt out by setting IgnoreCommit to false via OnSetCommitBehavior.
/// </summary>
/// <param name="GenJnlLine">The general journal line that is being posted.</param>
/// <param name="CheckLine">Indicates whether to check the lines before posting.</param>
local procedure Post(var GenJnlLine: Record "Gen. Journal Line"; CheckLine: Boolean)
var
IgnoreCommit: Boolean;
begin
IgnoreCommit := true;
OnSetCommitBehavior(IgnoreCommit);

if IgnoreCommit then
PostLineCommitBehaviorIgnore(GenJnlLine, CheckLine)
else
PostLine(GenJnlLine, CheckLine);
end;

/// <summary>
/// A wrapper procedure to delegate to PostLines in order to ignore commits.
/// While this procedure is on the call stack, the platform turns every Commit() into a no-op,
/// preventing intermittent duplicate-key errors on G/L Entry (table 17).
/// </summary>
/// <param name="GenJnlLine">The general journal line that is being posted.</param>
/// <param name="CheckLine">Indicates whether to check the line before posting.</param>
[CommitBehavior(CommitBehavior::Ignore)]
local procedure PostLineCommitBehaviorIgnore(var GenJnlLine: Record "Gen. Journal Line"; CheckLine: Boolean)
begin
PostLine(GenJnlLine, CheckLine);
end;

/// <summary>
/// Posting procedure for general journal lines
/// </summary>
/// <param name="GenJnlLine">The general journal line that is being posted.</param>
/// <param name="CheckLine">Indicates whether to check the line before posting.</param>
local procedure PostLine(var GenJnlLine: Record "Gen. Journal Line"; CheckLine: Boolean)
var
Balancing: Boolean;
IsTransactionConsistent: Boolean;
Expand Down Expand Up @@ -12859,4 +12897,9 @@ codeunit 12 "Gen. Jnl.-Post Line"
local procedure OnPostUnapplyOnBeforeInsertTempVATEntry(var VATEntry: Record "VAT Entry"; var UnapplyVATEntries: Boolean)
begin
end;

[IntegrationEvent(false, false)]
local procedure OnSetCommitBehavior(var IgnoreCommit: Boolean)
begin
end;
}
Loading
Loading