Slice 637899: [Expense Agent] More currencies and countries#8928
Open
BardurKnudsen wants to merge 3 commits into
Open
Slice 637899: [Expense Agent] More currencies and countries#8928BardurKnudsen wants to merge 3 commits into
BardurKnudsen wants to merge 3 commits into
Conversation
added 2 commits
June 30, 2026 14:48
Contributor
Copilot PR ReviewIteration 1 · Outcome: completed Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630 Orchestrator pre-filter (13 file(s) excluded)
Findings produced by the Copilot CLI agent against BCQuality at |
…SourceCurrencyOnGLEntry test
github-actions
Bot
added
the
needs-approval
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands demo/test support for additional currencies (and trims some localization-specific country/region demo creators), aligning the demo datasets with broader ISO-style coverage for the “Expense Agent” scenario.
Changes:
- Adds many additional currency codes to demo currency data and Contoso demo exchange rates.
- Updates multiple localized
Create Currencycodeunits to include expanded currency-name mappings and new label constants. - Adds missing test initialization in an SCM costing batch test, and removes several localization-specific
Create Country/Regioncodeunits.
Reviewed changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Layers/W1/Tests/SCM/SCMCostingBatch.Codeunit.al | Ensures the affected test runs required initialization before currency/setup-dependent logic. |
| src/Layers/W1/DemoTool/CreateCurrency.Codeunit.al | Expands currency description mapping and label set for demo currency creation. |
| src/Layers/NZ/DemoTool/CreateCurrency.Codeunit.al | Same currency expansion/mapping updates for NZ layer demo tool. |
| src/Layers/NL/DemoTool/CreateCurrency.Codeunit.al | Same currency expansion/mapping updates for NL layer demo tool. |
| src/Layers/NA/DemoTool/CreateCurrency.Codeunit.al | Same currency expansion/mapping updates for NA layer demo tool. |
| src/Layers/IN/DemoTool/CreateCurrency.Codeunit.al | Same currency expansion/mapping updates for IN layer demo tool. |
| src/Layers/FR/DemoTool/CreateCurrency.Codeunit.al | Same currency expansion/mapping updates for FR layer demo tool. |
| src/Layers/CA/DemoTool/CreateCurrency.Codeunit.al | Same currency expansion/mapping updates for CA layer demo tool. |
| src/Layers/RU/DemoTool/CreateCountryRegion.Codeunit.al | Removes RU-layer country/region demo creator codeunit. |
| src/Layers/CH/DemoTool/CreateCountryRegion.Codeunit.al | Removes CH-layer country/region demo creator codeunit. |
| src/Layers/BE/DemoTool/CreateCountryRegion.Codeunit.al | Removes BE-layer country/region demo creator codeunit (including IBAN flagging logic). |
| src/Layers/APAC/DemoTool/CreateCountryRegion.Codeunit.al | Removes APAC-layer country/region demo creator codeunit. |
| src/DemoTool/Pictures/CurrencyData.TXT | Adds many new currency rows to the demo tool’s currency seed data. |
| src/Apps/W1/ContosoCoffeeDemoDataset/app/DemoTool/Contoso Helpers/ContosoCurrency.Codeunit.al | Minor reordering of currency field validations during currency insert. |
| src/Apps/W1/ContosoCoffeeDemoDataset/app/DemoData/Finance/2.Master data/CreateCurrencyExchangeRate.Codeunit.al | Adds exchange rates for the newly introduced currency codes in the Contoso dataset. |
| src/Apps/W1/ContosoCoffeeDemoDataset/app/.resources/CurrencyData.TXT | Mirrors the expanded currency seed data for the Contoso dataset resources. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
665
to
+668
| '': | ||
| exit(''); | ||
| else | ||
| Error(CountryCodeDoesNotExistErr); | ||
| exit(CurrencyCode); |
| exit(''); | ||
| else | ||
| Error(CountryCodeDoesNotExistErr); | ||
| exit(CurrencyCode); |
| exit(''); | ||
| else | ||
| Error(CountryCodeDoesNotExistErr); | ||
| exit(CurrencyCode); |
| exit(''); | ||
| else | ||
| Error(CountryCodeDoesNotExistErr); | ||
| exit(CurrencyCode); |
| exit(''); | ||
| else | ||
| Error(CountryCodeDoesNotExistErr); | ||
| exit(CurrencyCode); |
| exit(''); | ||
| else | ||
| Error(CountryCodeDoesNotExistErr); | ||
| exit(CurrencyCode); |
| XEuroTxt: Label 'Euro'; | ||
| XAustraliandollarTxt: Label 'Australian dollar'; | ||
| XBulgarianlevaTxt: Label 'Bulgarian leva'; | ||
| XBruneiDarussalemdollarTxt: Label 'Brunei Darussalem dollar'; |
| XSwedishkronaTxt: Label 'Swedish krona'; | ||
| XSingaporedollarTxt: Label 'Singapore dollar'; | ||
| XSloveniantolarTxt: Label 'Slovenian tolar'; | ||
| XSaudiArabianryialTxt: Label 'Saudi Arabian ryial'; |
| XSwazilandlilangeniTxt: Label 'Swaziland lilangeni'; | ||
| XSlovakKorunaTxt: Label 'Slovak Koruna'; | ||
| XSerbianDinarTxt: Label 'Serbian Dinar'; | ||
| XTunesiandinarTxt: Label 'Tunesian dinar'; |
Comment on lines
+155
to
+156
| XAD;396;1;0.01;0.001;0.01;0;100;330;0;02:02;02:05 | ||
| XAF;950;1;1;0.1;1;0;100;665;0;00:00;00:03 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding more country/region codes and currencies, according to standard ISO lists.
fixes AB#637899