Trigger full PR build on changes under src/Layers#8939
Open
aholstrup1 wants to merge 1 commit into
Open
Conversation
Contributor
Copilot PR ReviewIteration 2 · Outcome: not-applicable
Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630 No findings were posted for this iteration. Orchestrator pre-filter (13 file(s) excluded)
Findings produced by the Copilot CLI agent against BCQuality at |
Add a fullBuildPatterns entry so any change under src/Layers forces a full Pull Request build. These layer folders are not referenced by any AL-Go project's appFolders/testFolders, so incremental builds matched such changes to zero projects and skipped every build job. Keeping incremental builds enabled preserves fast PR builds for normal app changes.
a7a6dc0 to
4d45399
Compare
mazhelez
approved these changes
Jul 1, 2026
spetersenms
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Incremental PR builds (
incrementalBuilds.onPull_Request: true) only build projects whoseappFolders/testFolderscover the modified files. Thesrc/Layers/*folders (for examplesrc/Layers/NL/BaseApp,src/Layers/W1/BaseApp) are consumed by projects but are not listed as project folders, so a PR that only touches a layer maps to zero projects. The "Determine Projects To Build" step then logsDid not find any projects to add to the build order, emitsProjectsJson=[], and every build job is skipped, producing a green PR build that compiled nothing.Rather than disable incremental builds entirely, this adds a
fullBuildPatternsentry forsrc/Layers/*. AL-Go'sDetermineProjectsToBuildmatches modified files against these patterns with PowerShell-like(where*spans path separators), so any change nested undersrc/Layersforces a full Pull Request build. Normal app-only changes keep fast incremental builds.Linked work
AB#640966
How I validated this
What I tested and the outcome
Configuration-only change to
.github/AL-Go-Settings.json; no app code affected, so no AL build or BC run applies. Root cause verified against the failing run on PR #8933 (run 28448705321), where the Initialization job loggedDid not find any projects to add to the build orderandProjectsJson=[], causing all Build jobs to be skipped. Pattern semantics confirmed from AL-GoDetermineProjectsToBuild.psm1(IsFullBuildRequireduses$modifiedFiles -like $fullBuildFolderafter joining with the base folder).Risk & compatibility
Low. Incremental builds stay enabled, so the only behavior change is that PRs touching
src/Layers/*now build all projects (intended). If additional shared-but-unmapped roots are found later, they can be added tofullBuildPatternsthe same way.